feat(dev,server-runtime): detect built mode via build.mode
#6964
Conversation
🦋 Changeset detectedLatest commit: 18bed1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pcattori
force-pushed
the
pedro/build-mode
branch
from
7cd6164 to
4d3317d
Compare
| @@ -4,5 +4,5 @@ import * as build from "@remix-run/dev/server-build"; | |||
| export const onRequest = createPagesFunctionHandler({ | |||
| build, | |||
| getLoadContext: (context) => context.env, | |||
| mode: process.env.NODE_ENV, | |||
| mode: build.mode, | |||
There was a problem hiding this comment.
Do we want to simplify createPagesFunctionHandler so we don't have to pass mode anymore and it gets automatically recognized?
There was a problem hiding this comment.
Conceptually, yes, but holding off on that since we are discussing better ways to configure dev-only options than to just lump them all under NODE_ENV=development
| @@ -5,7 +5,7 @@ import * as build from "@remix-run/dev/server-build"; | |||
|
|
|||
| const remixHandler = createRequestHandlerWithStaticFiles({ | |||
| build, | |||
| mode: Deno.env.get("NODE_ENV"), | |||
| mode: build.mode, | |||
There was a problem hiding this comment.
Same for createRequestHandlerWithStaticFiles?
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Relates to #6891