Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates(arc): update README #7482

Merged
merged 4 commits into from
Sep 19, 2023
Merged

templates(arc): update README #7482

merged 4 commits into from
Sep 19, 2023

Conversation

ngtrthinh169TPC
Copy link
Contributor

@ngtrthinh169TPC ngtrthinh169TPC commented Sep 19, 2023

Simply change the deploy command on docs for arc template.

Old one:

arc deploy production

New one:

npx arc deploy production

This should help clarify the command for people that takes docs literally (or a bit dull, like me), since arc is not a command and you have to add npx to it. The full command is documented on arc's quick start docs

Also updated the link to contribution guide.

This should help clarify the command for people that takes docs literally (like me), since `arc` is not a command and you have to add `npx` to it.
The full command is documented on [arc's quick start docs](https://arc.codes/docs/en/get-started/quickstart)
@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023

⚠️ No Changeset found

Latest commit: 54d6f24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 19, 2023

Hi @ngtrthinh169TPC,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 19, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

CONTRIBUTING.md is linking to the wrong file (404 not found). This would help newcomers to find it easier and make sure their contributions are not wasted by some miscommunications
@ngtrthinh169TPC ngtrthinh169TPC changed the title Update arc template's deploy command Update docs Sep 19, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
@brophdawg11
Copy link
Contributor

Thanks for the update!

@brophdawg11 brophdawg11 merged commit 52d431f into remix-run:main Sep 19, 2023
@MichaelDeBoey MichaelDeBoey changed the title Update docs templates(arc): update README Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants