-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error type to server runtime meta args #8238
Add error type to server runtime meta args #8238
Conversation
🦋 Changeset detectedLatest commit: dc7b786 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @timkraut, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
6667351
to
df4d4f8
Compare
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
df4534c
to
a64223e
Compare
a64223e
to
31399fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🤖 Hello there, We just published version Thanks! |
I think our CI bot is confused. This was merged to dev so is not included in the 2.4.0 prerelease |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Closes: There is no issue for this one yet
meta-test.tsx
file - no changes required)I have a Remix app on the latest version (
v2.3.1
) and with a lot of debugging, I've found out that theMetaFunction
type imported from'@remix-run/node'
differs from theMetaFunction
from'@remix-run/react'
. If there is an error thrown in theloader
withv.2.3.1
, theerror
is set as expected in JavaScript but the types yelled at me.Testing Strategy
MetaFunction
imported from'@remix-run/node'
error
property is included