Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-dev/vite): add Vite plugin adapter API #8514

Merged
merged 22 commits into from
Jan 18, 2024

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Jan 15, 2024

This is designed to be a minimal yet future-proofed adapter interface to support:

  • Defining an unstable_serverBundles function.
  • Defining a buildEnd hook for running arbitrary code after the Remix build has finished (since it's made of multiple Vite builds) with enough context to perform tasks like modifying the build output for a particular hosting platform.
  • Accessing and validating user options, e.g. so the adapter can throw if the user provides conflicting Remix plugin options.

Copy link

changeset-bot bot commented Jan 15, 2024

🦋 Changeset detected

Latest commit: 240cdad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish changed the title feat(remix-dev/vite): add Vite plugin adapter API WIP: feat(remix-dev/vite): add Vite plugin adapter API Jan 17, 2024
@markdalgleish markdalgleish marked this pull request as ready for review January 17, 2024 22:29
@markdalgleish markdalgleish changed the title WIP: feat(remix-dev/vite): add Vite plugin adapter API feat(remix-dev/vite): add Vite plugin adapter API Jan 17, 2024
@markdalgleish markdalgleish merged commit c358f41 into dev Jan 18, 2024
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/vite-plugin-adapter branch January 18, 2024 03:01
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 18, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 2.5.1-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.6.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Feb 1, 2024

🤖 Hello there,

We just published version 2.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants