-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quads to float lib #574
Add quads to float lib #574
Conversation
5fad2ab
to
26a7ee2
Compare
Updated to include changes to float_eq for 128 bit floats. |
26a7ee2
to
f0e0da5
Compare
@Alasdair It would be great to get this merged so that it doesn't fall behind as more features are added to the float library. @Incarnation-p-lee I'm happy to follow up with quad related addendums to your PRs, or feel free to include quad work in your PRs from the get go, whatever is easier for you. I just want to make sure that the final version of the sail float library has full quad floating point support so that the quad implementation in the RISC-V Sail model can use it when we switch over. |
Thanks @jordancarlin for making this happen, will include quad from the underlying PR in the test. |
Since #587 was merged first, I can go ahead and rebase this one tonight, and then going forward you can include quads if that works for you @Incarnation-p-lee. |
That makes much sense to me. Thanks again and will continue the rest floating API(s) with quad (aka 128 bits) support. |
f0e0da5
to
2d6e0d6
Compare
@Alasdair this has been rebased and should be ready to merge now. Ideally before more of the float lib is added. |
@Incarnation-p-lee Thanks for taking on 128 bit support with the rest of the float APIs. Let me know if you need any other help with it. |
Thanks a lot. I will plan to improve the test data of float lib after this patch merged. |
Thanks! |
This PR extends the fp types that have been created so far to support 128 bits and extends the existing test files to confirm correct operation on quads.
There is ongoing work to add quads to the riscv model (riscv/sail-riscv/pull/445), so including them in the float library that is being created seems like a good idea.