Pattern Completeness: Warn about future clauses in scattered enums #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now if matching on a scattered enum the completeness checker will warn
about the possibility of future members:
```
Warning: Incomplete pattern match statement at warn_enum_open.sail:16.2-7:
16 | match R {
| ^---^
|
The following expression is unmatched: <future E clause>
```
Which effectively requires a wildcard case for such matches to be complete.
After the `end` keyword closes the scattered definition this will no-longer
be the case, as no new clauses can be added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if matching on a scattered enum the completeness checker will warn about the possibility of future members:
Which effectively requires a wildcard case for such matches to be complete. After the
endkeyword closes the scattered definition this will no-longer be the case, as no new clauses can be added.