Restore support of file:// and gopher:// links. Fixes #96 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR remyhonig#88 introduced a regression where rmh-elfeed-org-mark-feed-ignore stopped working properly. The ignores were made in a temp buffer and not saved back.
sarg
commented
Jan 4, 2025
| @@ -3,9 +3,9 @@ | |||
| ;; Copyright (C) 2014 Remy Honig | |||
|
|
|||
| ;; Author : Remy Honig <[email protected]> | |||
| ;; Package-Requires : ((elfeed "1.1.1") (org "8.2.7") (cl-lib "0.5")) | |||
| ;; Package-Requires : ((emacs "28.1") (elfeed "1.1.1") (org "8.2.7")) | |||
There was a problem hiding this comment.
string-clean-whitespace requires 28.1
cl-lib is bundled in
| @@ -85,20 +85,21 @@ Return t if it does or nil if it does not." | |||
|
|
|||
| (defun rmh-elfeed-org-mark-feed-ignore (url) | |||
| "Set tag `rmh-elfeed-org-ignore-tag' to headlines containing the feed URL." | |||
| (dolist (org-file rmh-elfeed-org-files) | |||
| (with-temp-buffer | |||
There was a problem hiding this comment.
with-temp-buffer made this function ineffective. The changes were not saved to the disk
| (mapcar | ||
| (lambda (headline) | ||
| (let* ((text (car headline)) | ||
| (link-and-title (and (string-match "^\\[\\[\\(http.+?\\)\\]\\[\\(.+?\\)\\]\\]" text) |
There was a problem hiding this comment.
unused code, the headlines are already parsed in the input
| @@ -5,12 +5,6 @@ | |||
| (rmh-elfeed-org-cleanup-headlines '(("" elfeed tag1) ("" elfeed tag2)) 'elfeed) | |||
| '(("" tag1) ("" tag2))))) | |||
|
|
|||
| (xt-deftest rmh-elfeed-org-convert-headline-to-tagger-params | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.