Ensure test quality via linting (#72)

- Change test folders to packages to allow relative imports
- List standard modules first in imports
- Avoid unnecessary indenting of brackets
- Use whitespace around binary operators

tests/__init__.py

@@ -0,0 +1,8 @@
+# Copyright (c) 2023 Renata Hodovan, Akos Kiss.
+#
+# Licensed under the BSD 3-Clause License
+# <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
+# This file may not be copied, modified, or distributed except
+# according to those terms.
+
+# INTENTIONALLY EMPTY

tests/call/__init__.py

@@ -0,0 +1,8 @@
+# Copyright (c) 2023 Renata Hodovan, Akos Kiss.
+#
+# Licensed under the BSD 3-Clause License
+# <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
+# This file may not be copied, modified, or distributed except
+# according to those terms.
+
+# INTENTIONALLY EMPTY

tests/call/test_anonymize_decorator.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2016-2021 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2016-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
@@ -9,7 +9,7 @@
 
 import fuzzinator
 
-from common_call import MockAlwaysFailCall, MockNeverFailCall
+from .common_call import MockAlwaysFailCall, MockNeverFailCall
 
 
 @pytest.mark.parametrize('call_init_kwargs, call_kwargs', [

tests/call/test_exit_code_filter.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2016-2021 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2016-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
@@ -9,7 +9,7 @@
 
 import fuzzinator
 
-from common_call import MockAlwaysFailCall, MockNeverFailCall
+from .common_call import MockAlwaysFailCall, MockNeverFailCall
 
 
 @pytest.mark.parametrize('call_init_kwargs, call_kwargs', [

tests/call/test_file_reader_decorator.py

@@ -1,17 +1,18 @@
-# Copyright (c) 2017-2022 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2017-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
 # This file may not be copied, modified, or distributed except
 # according to those terms.
 
 import os
-import pytest
 import shutil
 
+import pytest
+
 import fuzzinator
 
-from common_call import blinesep, resources_dir, MockAlwaysFailCall, MockNeverFailCall
+from .common_call import blinesep, resources_dir, MockAlwaysFailCall, MockNeverFailCall
 
 
 @pytest.mark.parametrize('dec_kwargs', [

tests/call/test_file_writer_decorator.py

@@ -1,17 +1,18 @@
-# Copyright (c) 2016-2021 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2016-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
 # This file may not be copied, modified, or distributed except
 # according to those terms.
 
 import os
-import pytest
 import re
 
+import pytest
+
 import fuzzinator
 
-from common_call import MockAlwaysFailCall, MockNeverFailCall
+from .common_call import MockAlwaysFailCall, MockNeverFailCall
 
 
 @pytest.mark.parametrize('call_init_kwargs, call_kwargs', [

tests/call/test_platform_info_decorator.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2016-2021 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2016-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
@@ -9,7 +9,7 @@
 
 import fuzzinator
 
-from common_call import MockAlwaysFailCall, MockNeverFailCall
+from .common_call import MockAlwaysFailCall, MockNeverFailCall
 
 
 @pytest.mark.parametrize('call_init_kwargs, call_kwargs', [

tests/call/test_regex_filter.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2016-2021 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2016-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
@@ -9,7 +9,7 @@
 
 import fuzzinator
 
-from common_call import MockAlwaysFailCall, MockNeverFailCall
+from .common_call import MockAlwaysFailCall, MockNeverFailCall
 
 
 @pytest.mark.parametrize('call_init_kwargs, call_kwargs', [

tests/call/test_sanitizer_analyzer_decorator.py

@@ -1,17 +1,18 @@
 # Copyright (c) 2020 Tamas Keri
-# Copyright (c) 2020-2021 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2020-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
 # This file may not be copied, modified, or distributed except
 # according to those terms.
 
 import os
+
 import pytest
 
 import fuzzinator
 
-from common_call import resources_dir, MockAlwaysFailCall
+from .common_call import resources_dir, MockAlwaysFailCall
 
 
 @pytest.mark.parametrize('call_class, call_kwargs, exp', [

tests/call/test_stdin_subprocess_call.py

@@ -6,12 +6,13 @@
 # according to those terms.
 
 import os
-import pytest
 import sys
 
+import pytest
+
 import fuzzinator
 
-from common_call import linesep, resources_dir
+from .common_call import linesep, resources_dir
 
 
 @pytest.mark.parametrize('command, cwd, env, no_exit_code, test, exp', [
@@ -21,7 +22,7 @@
     (f'{sys.executable} {os.path.join(resources_dir, "mock_tool.py")} --echo-stdin --exit-code 1', resources_dir, None, None, b'foo', {'stdout': 'foo', 'stderr': '', 'exit_code': 1}),
     (f'{sys.executable} {os.path.join(resources_dir, "mock_tool.py")} --print-env BAR --echo-stdin --exit-code 1', resources_dir, '{"BAR": "baz"}', None, b'foo', {'stdout': f'baz{linesep}foo', 'stderr': '', 'exit_code': 1}),
     (f'{sys.executable} {os.path.join(resources_dir, "mock_tool.py")} --echo-stdin --exit-code 0', None, None, 'True', b'foo', {'stdout': 'foo', 'stderr': '', 'exit_code': 0}),
-    ])
+])
 def test_stdin_subprocess_call(command, cwd, env, no_exit_code, test, exp):
     call = fuzzinator.call.StdinSubprocessCall(command=command, cwd=cwd, env=env, no_exit_code=no_exit_code)
     with call:

tests/call/test_stream_monitored_subprocess_call.py

@@ -6,12 +6,13 @@
 # according to those terms.
 
 import os
-import pytest
 import sys
 
+import pytest
+
 import fuzzinator
 
-from common_call import linesep, resources_dir
+from .common_call import linesep, resources_dir
 
 
 @pytest.mark.skipif(not hasattr(fuzzinator.call, 'StreamMonitoredSubprocessCall'),

tests/call/test_subprocess_call.py

@@ -6,12 +6,13 @@
 # according to those terms.
 
 import os
-import pytest
 import sys
 
+import pytest
+
 import fuzzinator
 
-from common_call import linesep, resources_dir
+from .common_call import linesep, resources_dir
 
 
 @pytest.mark.parametrize('command, cwd, env, no_exit_code, test, exp', [

tests/call/test_subprocess_property_decorator.py

@@ -6,12 +6,13 @@
 # according to those terms.
 
 import os
-import pytest
 import sys
 
+import pytest
+
 import fuzzinator
 
-from common_call import linesep, resources_dir, MockAlwaysFailCall, MockNeverFailCall
+from .common_call import linesep, resources_dir, MockAlwaysFailCall, MockNeverFailCall
 
 
 @pytest.mark.parametrize('call_init_kwargs, call_kwargs', [

tests/call/test_unique_decorator.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2016-2021 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2016-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
@@ -9,7 +9,7 @@
 
 import fuzzinator
 
-from common_call import MockAlwaysFailCall, MockNeverFailCall
+from .common_call import MockAlwaysFailCall, MockNeverFailCall
 
 
 @pytest.mark.parametrize('call_init_kwargs, call_kwargs', [

tests/exporter/__init__.py

@@ -0,0 +1,8 @@
+# Copyright (c) 2023 Renata Hodovan, Akos Kiss.
+#
+# Licensed under the BSD 3-Clause License
+# <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
+# This file may not be copied, modified, or distributed except
+# according to those terms.
+
+# INTENTIONALLY EMPTY

tests/formatter/__init__.py

@@ -0,0 +1,8 @@
+# Copyright (c) 2023 Renata Hodovan, Akos Kiss.
+#
+# Licensed under the BSD 3-Clause License
+# <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
+# This file may not be copied, modified, or distributed except
+# according to those terms.
+
+# INTENTIONALLY EMPTY

tests/formatter/test_chevron_formatter.py

@@ -1,16 +1,17 @@
-# Copyright (c) 2018-2022 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2018-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
 # This file may not be copied, modified, or distributed except
 # according to those terms.
 
 import os
+
 import pytest
 
 import fuzzinator
 
-from common_formatter import mock_issue, mock_templates_dir
+from .common_formatter import mock_issue, mock_templates_dir
 
 
 @pytest.mark.parametrize('issue, formatter_init_kwargs, exp_short, exp_long', [

tests/formatter/test_jinja_formatter.py

@@ -1,16 +1,17 @@
-# Copyright (c) 2018-2022 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2018-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
 # This file may not be copied, modified, or distributed except
 # according to those terms.
 
 import os
+
 import pytest
 
 import fuzzinator
 
-from common_formatter import mock_issue, mock_templates_dir
+from .common_formatter import mock_issue, mock_templates_dir
 
 
 @pytest.mark.parametrize('issue, formatter_init_kwargs, exp_short, exp_long', [

tests/formatter/test_markdown_decorator.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2018-2022 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2018-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
@@ -9,7 +9,7 @@
 
 import fuzzinator
 
-from common_formatter import MockFixedFormatter, MockIdFormatter
+from .common_formatter import MockFixedFormatter, MockIdFormatter
 
 
 @pytest.mark.parametrize('issue, formatter_class, formatter_init_kwargs, exp_short, exp_long', [

tests/formatter/test_string_formatter.py

@@ -1,16 +1,17 @@
-# Copyright (c) 2018-2021 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2018-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
 # This file may not be copied, modified, or distributed except
 # according to those terms.
 
 import os
+
 import pytest
 
 import fuzzinator
 
-from common_formatter import mock_issue, mock_templates_dir
+from .common_formatter import mock_issue, mock_templates_dir
 
 
 @pytest.mark.parametrize('issue, formatter_init_kwargs, exp_short, exp_long', [

tests/fuzzer/__init__.py

@@ -0,0 +1,8 @@
+# Copyright (c) 2023 Renata Hodovan, Akos Kiss.
+#
+# Licensed under the BSD 3-Clause License
+# <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
+# This file may not be copied, modified, or distributed except
+# according to those terms.
+
+# INTENTIONALLY EMPTY

tests/fuzzer/test_byte_flip_decorator.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2017-2021 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2017-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
@@ -9,7 +9,7 @@
 
 import fuzzinator
 
-from common_fuzzer import MockExhaustedFuzzer, MockRepeatingFuzzer
+from .common_fuzzer import MockExhaustedFuzzer, MockRepeatingFuzzer
 
 
 @pytest.mark.parametrize('fuzzer_class, fuzzer_init_kwargs, dec_kwargs, exp_flip_cnt', [

tests/fuzzer/test_fuzzer_file_writer_decorator.py

@@ -1,17 +1,18 @@
-# Copyright (c) 2017-2021 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2017-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
 # This file may not be copied, modified, or distributed except
 # according to those terms.
 
 import os
-import pytest
 import re
 
+import pytest
+
 import fuzzinator
 
-from common_fuzzer import MockExhaustedFuzzer, MockRepeatingFuzzer
+from .common_fuzzer import MockExhaustedFuzzer, MockRepeatingFuzzer
 
 
 @pytest.mark.parametrize('fuzzer_class, fuzzer_init_kwargs, dec_kwargs, exp', [

tests/fuzzer/test_list_directory.py

@@ -1,17 +1,17 @@
-# Copyright (c) 2016-2021 Renata Hodovan, Akos Kiss.
+# Copyright (c) 2016-2023 Renata Hodovan, Akos Kiss.
 #
 # Licensed under the BSD 3-Clause License
 # <LICENSE.rst or https://opensource.org/licenses/BSD-3-Clause>.
 # This file may not be copied, modified, or distributed except
 # according to those terms.
 
-import pytest
-
 from os.path import join
 
+import pytest
+
 import fuzzinator
 
-from common_fuzzer import blinesep, resources_dir
+from .common_fuzzer import blinesep, resources_dir
 
 mock_tests = join(resources_dir, 'mock_tests')