Skip to content

Commit

Permalink
PR feedback - don't rename types
Browse files Browse the repository at this point in the history
  • Loading branch information
steved committed Oct 24, 2024
1 parent 1303d1d commit 5936baf
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions lib/modules/manager/circleci/extract.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ import { getDep } from '../dockerfile/extract';
import type { PackageDependency, PackageFileContent } from '../types';
import {
CircleCiFile,

Check failure on line 9 in lib/modules/manager/circleci/extract.ts

View workflow job for this annotation

GitHub Actions / lint-other

Duplicate identifier 'CircleCiFile'.

Check failure on line 9 in lib/modules/manager/circleci/extract.ts

View workflow job for this annotation

GitHub Actions / build

Duplicate identifier 'CircleCiFile'.
type CircleCiFile as CircleCiFileType,
type CircleCiJob as CircleCiJobType,
type CircleCiOrb as CircleCiOrbType,
type CircleCiFile,

Check failure on line 10 in lib/modules/manager/circleci/extract.ts

View workflow job for this annotation

GitHub Actions / lint-other

Duplicate identifier 'CircleCiFile'.

Check failure on line 10 in lib/modules/manager/circleci/extract.ts

View workflow job for this annotation

GitHub Actions / build

Duplicate identifier 'CircleCiFile'.
type CircleCiJob,
type CircleCiOrb,
} from './schema';

function extractDefinition(
definition: CircleCiOrbType | CircleCiFileType,
definition: CircleCiOrb | CircleCiFile,
packageFile?: string,
): PackageDependency[] {
const deps: PackageDependency[] = [];
Expand All @@ -37,7 +37,7 @@ function extractDefinition(
}

// extract environments
const environments: CircleCiJobType[] = [
const environments: CircleCiJob[] = [
Object.values(definition.executors ?? {}),
Object.values(definition.jobs ?? {}),
].flat();
Expand Down

0 comments on commit 5936baf

Please sign in to comment.