Poetry: keep querying pypi.org even if we find other registries.

renovatebot · Sep 21, 2019 · 93c072d · 93c072d
1 parent 324301a
commit 93c072d
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/lib/manager/poetry/extract.ts b/lib/manager/poetry/extract.ts
@@ -88,12 +88,12 @@ function extractFromSection(
 
 function extractRegistries(pyprojectfile: PoetryFile): string[] {
   const sources = pyprojectfile.tool.poetry.source;
+  const registryUrls: string[] = ['https://pypi.org/pypi/'];
 
   if (!Array.isArray(sources)) {
-    return [];
+    return registryUrls;
   }
 
-  const registryUrls: string[] = [];
   for (const source of sources) {
     if (source.url) {
       registryUrls.push(source.url);

diff --git a/test/manager/poetry/__snapshots__/extract.spec.ts.snap b/test/manager/poetry/__snapshots__/extract.spec.ts.snap
@@ -1,5 +1,17 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`lib/manager/poetry/extract extractPackageFile() can parse empty registries 1`] = `
+Array [
+  "https://pypi.org/pypi/",
+]
+`;
+
+exports[`lib/manager/poetry/extract extractPackageFile() can parse missing registries 1`] = `
+Array [
+  "https://pypi.org/pypi/",
+]
+`;
+
 exports[`lib/manager/poetry/extract extractPackageFile() extracts multiple dependencies (with dep = {version = "1.2.3"} case) 1`] = `
 Array [
   Object {
@@ -159,6 +171,7 @@ Array [
 
 exports[`lib/manager/poetry/extract extractPackageFile() extracts registries 1`] = `
 Array [
+  "https://pypi.org/pypi/",
   "https://foo.bar/simple/",
   "https://bar.baz/+simple/",
 ]

diff --git a/test/manager/poetry/extract.spec.ts b/test/manager/poetry/extract.spec.ts
@@ -70,15 +70,17 @@ describe('lib/manager/poetry/extract', () => {
     it('extracts registries', () => {
       const res = extractPackageFile(pyproject6toml, config);
       expect(res.registryUrls).toMatchSnapshot();
-      expect(res.registryUrls).toHaveLength(2);
+      expect(res.registryUrls).toHaveLength(3);
     });
     it('can parse empty registries', () => {
       const res = extractPackageFile(pyproject7toml, config);
-      expect(res.registryUrls).toEqual([]);
+      expect(res.registryUrls).toMatchSnapshot();
+      expect(res.registryUrls).toHaveLength(1);
     });
     it('can parse missing registries', () => {
       const res = extractPackageFile(pyproject1toml, config);
-      expect(res.registryUrls).toEqual([]);
+      expect(res.registryUrls).toMatchSnapshot();
+      expect(res.registryUrls).toHaveLength(1);
     });
     it('skips git dependencies', () => {
       const content =