-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/regex)!: allow arbitrary regex groups for templates #12296
feat(manager/regex)!: allow arbitrary regex groups for templates #12296
Conversation
7091412
to
1765280
Compare
@secustor could you write the BREAKING CHANGE description a little clearer? We'll issue a new major release in the next few working days once GOPROXY changes are ready |
@secustor can you resolve the merge conflict? |
# Conflicts: # lib/manager/regex/index.ts
@rarkins Done. |
Is it possible to separate out the refactor from the breaking change? It's currently pretty hard to review due to the file changes. |
I have reverted the addition of an But I'm not sure what is missing for codecov. In my overview there is no reference to the offending lines |
The idea was to open a new pr with just the refactoring, so we can merge that before this.
I think this is only a codecov issue, as there are no coverage changes. 🤷♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to change our own regex managers or will they work as before?
Looks good so far
…into allow_arbitrary_capture_groups
I thought it would be easier to create a PR for this when the changes are released than vice versa. If you are referring to https://github.com/renovatebot/.github/blob/main/default.json, then no changes are necessary as this only affects regex managers with matchStringStrategy |
) Allow the usage of arbitrary capture groups inside of regex manager templates and further adds refactor which this allows. BREAKING_CHANGE Only regex managers using the combination matchStringStrategy are affected of this change! Currently capture groups which are empty but still match the regex are ignored. This is no longer the case! Subsequent matchGroups will now overwrite previous ones, even if the later one is empty.
) Allow the usage of arbitrary capture groups inside of regex manager templates and further adds refactor which this allows. BREAKING_CHANGE Only regex managers using the combination matchStringStrategy are affected of this change! Currently capture groups which are empty but still match the regex are ignored. This is no longer the case! Subsequent matchGroups will now overwrite previous ones, even if the later one is empty.
Changes:
This PR allows the usage of arbitrary capture groups inside of regex manager templates and further adds refactor which this allows.
BREAKING_CHANGE
Only regex managers using the
combination
matchStringStrategy are affected of this change!Currently capture groups which are empty but still match the regex are ignored.
This is no longer the case!
Subsequent matchGroups will now overwrite previous ones, even if the later one is empty.
Context:
Fixes #11387
Related: #12279
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: