-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Flux package manager that can renovate HelmRelease manifests #13566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some defensive non-null checks added in quite a few places, unless the response is first fully validated to conform to the TS type(s)
Co-authored-by: HonkingGoose <[email protected]>
Any chance we can cover a flux kustomization in this PR? It would resolve #12139 |
@anthr76 I read through #12139 but it's not clear to me what needs to be renovated in |
Sure Here's a few usecase examples.. Looking back I suppose this is more or less for a gitReository spec
I glue these together today with a regex manager https://github.com/anthr76/infra/blob/ab4463314fe1cca8d5af2b440a30e2281f7ab7ba/.github/renovate.json5#L38-L49 basically looking at it's source and updating the git tags most of the time. |
Got it. I don't currently use |
@anthr76 can you create a feature request for the additional features? Either create once this is merged or assume this PR will be merged soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confusion over extractAllPackageFiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for doc fixes 🤗
Co-authored-by: HonkingGoose <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the docs now. 😄
🚀 |
🎉 This PR is included in version 31.35.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
How long does it take new builds to make it to Docker Hub? Was hoping to update my GitLab Renovate runner to use this release, but I don't see it on Docker Hub yet. |
Usually a few hours. Keep an eye on the renovatebot/docker-renovate-full repo |
Awesome, I see the |
Adds a new
flux
package manager that parsesHelmRelease
andHelmRepository
manifests. Mostly code adapted from thehelmfile
,gitlabci
, andkubernetes
managers. Closes #5984.SkipReason
returned when failing to match aHelmRelease
to aHelmRepository
This was my first time writing TypeScript, and it was really quite pleasant! 🙂