feat(manager:npm): support `binarySource=install` for yarn #15414

viceice · 2022-05-03T08:54:38Z

Changes

support binarySource=install for yarn
use corepack if packageManager field is found.

Context

closes Yarn lock file maintenance using wrong version #14797
closes feat: support corepack + yarn #15173

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository

…ints

lib/modules/manager/npm/post-update/yarn.ts

viceice · 2022-05-03T10:08:52Z

Don't merge yet, needs builds to finish

lib/modules/manager/npm/post-update/yarn.spec.ts

lib/modules/manager/npm/post-update/__snapshots__/yarn.spec.ts.snap

lib/modules/manager/npm/post-update/yarn.ts

…ints

viceice · 2022-05-03T14:17:52Z

needs another buble

containerbase/base@1307333

otherwise this error occures:

Installing legacy tool corepack v0.10.0

added 1 package in 588ms
0.10.0
3.1.0
Usage Error: This project is configured to use yarn

$ pnpm ...

chore(deps): update dependency webpack to v5.69.1 renovate-reproductions/14797-renovate-corepack-yarn#1 (comment)

viceice · 2022-05-03T19:22:20Z

works 🥳 🎉

https://github.com/renovate-reproductions/14797-renovate-corepack-yarn/pulls

…ints

renovate-release · 2022-05-04T06:49:59Z

🎉 This PR is included in version 32.41.0 🎉

The release is available on:

GitHub release
32.41.0

Your semantic-release bot 📦🚀

bobvandevijver · 2022-05-05T06:47:48Z

@viceice Since this morning I'm seeing bash: yarn: command not found in my newly created renovate mrs, could this be related to this change?

…rn (#15414)" This reverts commit 03b2882.

rarkins · 2022-05-05T06:56:36Z

Created #15458 to prepare for possible revert of recent yarn changes

rarkins · 2022-05-05T07:28:43Z

@bobvandevijver hosted app or self-hosted?

bobvandevijver · 2022-05-05T07:29:44Z

Self-hosted on Gitlab, using the slim image version v32.41.2.

rarkins · 2022-05-05T07:39:16Z

Can you copy paste here the docker run command for one of the commands which failed? We think it's related to tags with a v prefix, e.g. selecting v16.10.0 instead of 16.10.0

bobvandevijver · 2022-05-05T07:44:00Z

{"name":"renovate","hostname":"runner-3cixccwz-project-43-concurrent-0","pid":14,"level":20,"logContext":"2fGWC0V2gIC-U8Ca6fG5F","repository":"extern/project","branch":"renovate/core-js-3.x","image":"node","msg":"Using docker to execute","time":"2022-05-05T07:30:09.380Z","v":0}
{"name":"renovate","hostname":"runner-3cixccwz-project-43-concurrent-0","pid":14,"level":20,"logContext":"2fGWC0V2gIC-U8Ca6fG5F","repository":"extern/project","branch":"renovate/core-js-3.x","toolName":"yarn-slim","constraint":"^1.22.18","resolvedVersion":"1.22.18","msg":"Resolved version","time":"2022-05-05T07:30:09.547Z","v":0}
{"name":"renovate","hostname":"runner-3cixccwz-project-43-concurrent-0","pid":14,"level":20,"logContext":"2fGWC0V2gIC-U8Ca6fG5F","repository":"extern/project","branch":"renovate/core-js-3.x","image":"docker.io/renovate/node","msg":"No tag or tagConstraint specified","time":"2022-05-05T07:30:09.547Z","v":0}
{"name":"renovate","hostname":"runner-3cixccwz-project-43-concurrent-0","pid":14,"level":20,"logContext":"2fGWC0V2gIC-U8Ca6fG5F","repository":"extern/project","branch":"renovate/core-js-3.x","msg":"Fetching Docker image: docker.io/renovate/node","time":"2022-05-05T07:30:09.548Z","v":0}
{"name":"renovate","hostname":"runner-3cixccwz-project-43-concurrent-0","pid":14,"level":20,"logContext":"2fGWC0V2gIC-U8Ca6fG5F","repository":"extern/project","branch":"renovate/core-js-3.x","msg":"Finished fetching Docker image","time":"2022-05-05T07:30:10.782Z","v":0}
{"name":"renovate","hostname":"runner-3cixccwz-project-43-concurrent-0","pid":14,"level":20,"logContext":"2fGWC0V2gIC-U8Ca6fG5F","repository":"extern/project","branch":"renovate/core-js-3.x","command":"docker run --rm --name=renovate_node --label=renovate_child -v \"/cache/renovate/drenso/repos/gitlab/extern/project\":\"/cache/renovate/drenso/repos/gitlab/extern/project\" -v \"/cache/renovate/drenso/cache\":\"/cache/renovate/drenso/cache\" -e NPM_CONFIG_CACHE -e npm_config_store -e CI -e YARN_CACHE_FOLDER -w \"/cache/renovate/drenso/repos/gitlab/extern/project\" docker.io/renovate/node bash -l -c \"install-tool yarn-slim 1.22.18 && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\"","msg":"Executing command","time":"2022-05-05T07:30:10.836Z","v":0}
{"name":"renovate","hostname":"runner-3cixccwz-project-43-concurrent-0","pid":14,"level":20,"logContext":"2fGWC0V2gIC-U8Ca6fG5F","repository":"extern/project","branch":"renovate/core-js-3.x","err":{"code":127,"killed":false,"signal":null,"cmd":"docker run --rm --name=renovate_node --label=renovate_child -v \"/cache/renovate/drenso/repos/gitlab/extern/project\":\"/cache/renovate/drenso/repos/gitlab/extern/project\" -v \"/cache/renovate/drenso/cache\":\"/cache/renovate/drenso/cache\" -e NPM_CONFIG_CACHE -e npm_config_store -e CI -e YARN_CACHE_FOLDER -w \"/cache/renovate/drenso/repos/gitlab/extern/project\" docker.io/renovate/node bash -l -c \"install-tool yarn-slim 1.22.18 && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\"","stdout":"Installing legacy tool yarn-slim v1.22.18\n\nadded 1 package in 1s\n1.22.18\n","stderr":"bash: yarn: command not found\n","message":"Command failed: docker run --rm --name=renovate_node --label=renovate_child -v \"/cache/renovate/drenso/repos/gitlab/extern/project\":\"/cache/renovate/drenso/repos/gitlab/extern/project\" -v \"/cache/renovate/drenso/cache\":\"/cache/renovate/drenso/cache\" -e NPM_CONFIG_CACHE -e npm_config_store -e CI -e YARN_CACHE_FOLDER -w \"/cache/renovate/drenso/repos/gitlab/extern/project\" docker.io/renovate/node bash -l -c \"install-tool yarn-slim 1.22.18 && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\"\nbash: yarn: command not found\n","stack":"Error: Command failed: docker run --rm --name=renovate_node --label=renovate_child -v \"/cache/renovate/drenso/repos/gitlab/extern/project\":\"/cache/renovate/drenso/repos/gitlab/extern/project\" -v \"/cache/renovate/drenso/cache\":\"/cache/renovate/drenso/cache\" -e NPM_CONFIG_CACHE -e npm_config_store -e CI -e YARN_CACHE_FOLDER -w \"/cache/renovate/drenso/repos/gitlab/extern/project\" docker.io/renovate/node bash -l -c \"install-tool yarn-slim 1.22.18 && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\"\nbash: yarn: command not found\n\n    at ChildProcess.exithandler (node:child_process:398:12)\n    at ChildProcess.emit (node:events:527:28)\n    at ChildProcess.emit (node:domain:475:12)\n    at maybeClose (node:internal/child_process:1092:16)\n    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)"},"msg":"rawExec err","time":"2022-05-05T07:30:13.833Z","v":0}
{"name":"renovate","hostname":"runner-3cixccwz-project-43-concurrent-0","pid":14,"level":20,"logContext":"2fGWC0V2gIC-U8Ca6fG5F","repository":"extern/project","branch":"renovate/core-js-3.x","err":{"code":127,"killed":false,"signal":null,"cmd":"docker run --rm --name=renovate_node --label=renovate_child -v \"/cache/renovate/drenso/repos/gitlab/extern/project\":\"/cache/renovate/drenso/repos/gitlab/extern/project\" -v \"/cache/renovate/drenso/cache\":\"/cache/renovate/drenso/cache\" -e NPM_CONFIG_CACHE -e npm_config_store -e CI -e YARN_CACHE_FOLDER -w \"/cache/renovate/drenso/repos/gitlab/extern/project\" docker.io/renovate/node bash -l -c \"install-tool yarn-slim 1.22.18 && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\"","stdout":"Installing legacy tool yarn-slim v1.22.18\n\nadded 1 package in 1s\n1.22.18\n","stderr":"bash: yarn: command not found\n","message":"Command failed: docker run --rm --name=renovate_node --label=renovate_child -v \"/cache/renovate/drenso/repos/gitlab/extern/project\":\"/cache/renovate/drenso/repos/gitlab/extern/project\" -v \"/cache/renovate/drenso/cache\":\"/cache/renovate/drenso/cache\" -e NPM_CONFIG_CACHE -e npm_config_store -e CI -e YARN_CACHE_FOLDER -w \"/cache/renovate/drenso/repos/gitlab/extern/project\" docker.io/renovate/node bash -l -c \"install-tool yarn-slim 1.22.18 && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\"\nbash: yarn: command not found\n","stack":"Error: Command failed: docker run --rm --name=renovate_node --label=renovate_child -v \"/cache/renovate/drenso/repos/gitlab/extern/project\":\"/cache/renovate/drenso/repos/gitlab/extern/project\" -v \"/cache/renovate/drenso/cache\":\"/cache/renovate/drenso/cache\" -e NPM_CONFIG_CACHE -e npm_config_store -e CI -e YARN_CACHE_FOLDER -w \"/cache/renovate/drenso/repos/gitlab/extern/project\" docker.io/renovate/node bash -l -c \"install-tool yarn-slim 1.22.18 && yarn install --ignore-engines --ignore-platform --network-timeout 100000 --ignore-scripts\"\nbash: yarn: command not found\n\n    at ChildProcess.exithandler (node:child_process:398:12)\n    at ChildProcess.emit (node:events:527:28)\n    at ChildProcess.emit (node:domain:475:12)\n    at maybeClose (node:internal/child_process:1092:16)\n    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)"},"type":"yarn","msg":"lock file error","time":"2022-05-05T07:30:13.896Z","v":0}

rarkins · 2022-05-05T07:57:32Z

Thanks, working on a fix in next 1-2 hours (it requires a lot of images to be rebuilt and pushed to Docker Hub)

bobvandevijver · 2022-05-05T11:04:08Z

Yes, it is fixed now 😃

viceice · 2022-05-05T15:07:41Z

sorry for the issues, i only tested latest renovate against the image changes and did not though about these recent yarn changes.

viceice added 2 commits May 3, 2022 10:52

feat(manager:npm): support binarySource=install

590e14c

fix: revert change (used by lerna)

601a2df

viceice mentioned this pull request May 3, 2022

fix(manager:npm): support yarn-path in repo sub-dir #15415

Merged

6 tasks

viceice added 3 commits May 3, 2022 11:21

Merge remote-tracking branch 'origin/main' into feat/yarn-tool-contra…

3020f20

…ints

fix: wrong datasource

c495697

fix: pin global yarn to v1

79459c9

viceice commented May 3, 2022

View reviewed changes

lib/modules/manager/npm/post-update/yarn.ts Outdated Show resolved Hide resolved

viceice requested a review from rarkins May 3, 2022 10:08

fix: use extract phase for package manager detection

b7b200b

viceice commented May 3, 2022

View reviewed changes

lib/modules/manager/npm/post-update/yarn.spec.ts Outdated Show resolved Hide resolved

lib/modules/manager/npm/post-update/__snapshots__/yarn.spec.ts.snap Outdated Show resolved Hide resolved

viceice added 2 commits May 3, 2022 12:31

Apply suggestions from code review

5efba10

test: simplify test

e39634b

viceice commented May 3, 2022

View reviewed changes

lib/modules/manager/npm/post-update/yarn.ts Outdated Show resolved Hide resolved

viceice added 2 commits May 3, 2022 13:44

Merge remote-tracking branch 'origin/main' into feat/yarn-tool-contra…

517e8ec

…ints

test: update snapshot

05792db

Merge branch 'main' into feat/yarn-tool-contraints

3909d43

viceice marked this pull request as ready for review May 3, 2022 19:22

viceice requested a review from JamieMagee May 3, 2022 19:22

viceice added 4 commits May 4, 2022 07:04

Merge remote-tracking branch 'origin/main' into feat/yarn-tool-contra…

8488955

…ints

fix: force slim yarn when v1 is requested

341c1f2

test: use object matcher instead of snapshot

de26273

test: more specific tests

b6f783a

rarkins approved these changes May 4, 2022

View reviewed changes

viceice changed the title ~~feat(manager:npm): support binarySource=install~~ feat(manager:npm): support binarySource=install for yarn May 4, 2022

viceice merged commit 03b2882 into main May 4, 2022

viceice deleted the feat/yarn-tool-contraints branch May 4, 2022 06:32

viceice mentioned this pull request May 4, 2022

fix(manager:npm): patch local yarn v1 binary #15440

Merged

6 tasks

rarkins added a commit that referenced this pull request May 5, 2022

fix: Revert "feat(manager:npm): support binarySource=install for ya…

f5774e0

…rn (#15414)" This reverts commit 03b2882.

github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(manager:npm): support `binarySource=install` for yarn #15414

feat(manager:npm): support `binarySource=install` for yarn #15414

viceice commented May 3, 2022 •

edited

Loading

viceice commented May 3, 2022 •

edited

Loading

viceice commented May 3, 2022 •

edited

Loading

viceice commented May 3, 2022

renovate-release commented May 4, 2022

bobvandevijver commented May 5, 2022

rarkins commented May 5, 2022

rarkins commented May 5, 2022

bobvandevijver commented May 5, 2022

rarkins commented May 5, 2022

bobvandevijver commented May 5, 2022

rarkins commented May 5, 2022

bobvandevijver commented May 5, 2022

viceice commented May 5, 2022

feat(manager:npm): support binarySource=install for yarn #15414

feat(manager:npm): support binarySource=install for yarn #15414

Conversation

viceice commented May 3, 2022 • edited Loading

Changes

Context

Documentation (please check one with an [x])

How I've tested my work (please tick one)

viceice commented May 3, 2022 • edited Loading

viceice commented May 3, 2022 • edited Loading

viceice commented May 3, 2022

renovate-release commented May 4, 2022

bobvandevijver commented May 5, 2022

rarkins commented May 5, 2022

rarkins commented May 5, 2022

bobvandevijver commented May 5, 2022

rarkins commented May 5, 2022

bobvandevijver commented May 5, 2022

rarkins commented May 5, 2022

bobvandevijver commented May 5, 2022

viceice commented May 5, 2022

feat(manager:npm): support `binarySource=install` for yarn #15414

feat(manager:npm): support `binarySource=install` for yarn #15414

viceice commented May 3, 2022 •

edited

Loading

viceice commented May 3, 2022 •

edited

Loading

viceice commented May 3, 2022 •

edited

Loading