Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved patterns (label, call and jump) #142

Merged
merged 1 commit into from
Jun 11, 2022
Merged

Improved patterns (label, call and jump) #142

merged 1 commit into from
Jun 11, 2022

Conversation

duckdoom4
Copy link
Collaborator

@duckdoom4 duckdoom4 commented Jun 11, 2022 •
edited
Loading

  • Labels now check for existing and invalid names
  • Call and jump now support from and pass statements
  • Modified to code to be more modular
  • Fixed some \t uses where \\t should be used

@duckdoom4
edit: Improved label, call and jump
a36ed06 
+ labels now check for existing and invalid names
+ call and jump now support from and pass statements
* modified to code to be more modular
* fixed some \t uses where \\t should be used
@duckdoom4 duckdoom4 added enhancement Small improvements topic:syntax labels Jun 11, 2022
@duckdoom4 duckdoom4 added this to the 2.1.0 milestone Jun 11, 2022
@duckdoom4 duckdoom4 requested a review from LuqueDaniel June 11, 2022 13:34
LuqueDaniel
LuqueDaniel approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@LuqueDaniel LuqueDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

As always, thanks for your contributions @JelleInfinity

@LuqueDaniel LuqueDaniel merged commit 6049502 into renpy:new-syntax Jun 11, 2022
@duckdoom4 duckdoom4 deleted the better-patterns branch June 11, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuqueDaniel LuqueDaniel LuqueDaniel approved these changes

Assignees
No one assigned
Labels
enhancement Small improvements topic:syntax
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@duckdoom4 @LuqueDaniel