Tokenizer updates #317
Merged
Tokenizer updates #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
duckdoom4
commented
Jun 1, 2023
•
duckdoom4
commented
- Split the atl patterns into it's own file
- Auto generate token files from language files
- Fixed a whole bunch of bugs in the tokenizer
- Tokenizer code should be a bit more readable now
- It's slower now, had to redo some parts to make it functional.
- I already have some ideas on how to speed it up a lot, but needs some more work.
- Had to add some temporary tokens for the python grammar file that should be changed later
- Fixed custom color injection code. (Fixes this comment from @FaceCrap)
Something is still causing the tokenizer to misalign when using the generated patterns. I'll try to fix it tomorrow
This is to match the behaviour of textmate, where the top most token is the last token added
This allows the end pattern of a range to extend based on the content pattern matches
Due to the way typescript initializes const object, we can't have circular references to patterns. To fix that, we just push all external dependencies in a shared file after all other files have been loaded.
Remove use of \G as javascript's regex engine doesn't support it Other fixes to make sure we can tokenize the python grammar file Change some renpy keyword to display as control flow keywords
duckdoom4
force-pushed
the
update-custom-containers
branch
from
61d42d9 to
a5f33cb
Compare
|
@LuqueDaniel Can we make it so this isn't checked on any
|
|
The workflow runs the |
Got it, fixed now :) |
LuqueDaniel
reviewed
Jun 2, 2023
Will add a special rule in our development area for displaying these in red
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.