Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #344

Merged
merged 10 commits into from
Jun 14, 2023
Merged

Update deps #344

merged 10 commits into from
Jun 14, 2023

Conversation

duckdoom4
Copy link
Collaborator

@duckdoom4 duckdoom4 commented Jun 14, 2023

  • Fix to allow absolute include paths
  • Minor code quality improvements with related settings
  • Target ESNext / NodeNext for latest feature support
  • Update node_module deps to latest version
  • Upgrade vscode engine version to v1.79.0

@duckdoom4 duckdoom4 requested a review from LuqueDaniel June 14, 2023 11:19
@LuqueDaniel
Copy link
Member

Is it required to upgrade vscode engine to 1.79.0? With this change, the extension can only be used with the latest version of vscode. On the other hand, it is usual to have vscode updated.

@duckdoom4
Copy link
Collaborator Author

No, not required. It should be at least 1.75.0

LuqueDaniel
LuqueDaniel previously approved these changes Jun 14, 2023
Copy link
Member

@LuqueDaniel LuqueDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTPM! 🎉

Then downgrade vscode engine to 1.75.

@duckdoom4 duckdoom4 merged commit ab6f5d5 into develop Jun 14, 2023
@duckdoom4 duckdoom4 deleted the update-deps branch June 14, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] - Extension alters workspace.settings.json with incorrect settings
2 participants