Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logger to use new logger convention #351

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Update logger to use new logger convention #351

merged 1 commit into from
Jun 23, 2023

Conversation

duckdoom4
Copy link
Collaborator

  • vscode provides a build in logger with log level system (command: Developer: Set Log Level...)
  • Converted the log grammar to be injection since the log channel doesn't support swapping languages and the original log grammar is lacking severely
  • Added code to only log to the debug console in extension debug mode

@duckdoom4
Update logger to use new logger convention
c4295c3 
- vscode provides a build in logger with log level system (command: `Developer: Set Log Level...`)
- Converted the log grammar to be injection since the log channel doesn't support swapping languages and the original log grammar is lacking severely
- Added code to only log to the debug console in extension debug mode
@duckdoom4 duckdoom4 requested a review from LuqueDaniel June 23, 2023 13:14
LuqueDaniel
LuqueDaniel approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@LuqueDaniel LuqueDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@duckdoom4 duckdoom4 merged commit 73fbc89 into develop Jun 23, 2023
@duckdoom4 duckdoom4 deleted the update-logger branch June 23, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuqueDaniel LuqueDaniel LuqueDaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duckdoom4 @LuqueDaniel