Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Cannot update part type, new part is always added #246

Closed
dubajj opened this issue Jan 4, 2024 · 2 comments · Fixed by #255
Closed

[Bug]: Cannot update part type, new part is always added #246

dubajj opened this issue Jan 4, 2024 · 2 comments · Fixed by #255
Assignees
@replaysMike
Labels
bug Something isn't working
Milestone
v2.6.1

Comments

@dubajj
Copy link

dubajj commented Jan 4, 2024

Binner version

v2.6.0

Operating System

Windows

Describe the bug and the steps to reproduce it

  1. Open an item from the inventory, here i opened OPA1678
    image

  2. Note that its placed under "IC" instead of "Opamp" so update the field to opamp
    image

  3. Press save to update the item
    image

note that its trying to add a new part instead of updating the existing part

Would you like to attach your appsetings.json configuration?

No response

Screenshots or Videos (Optional, but they help!)

No response

Are you able to contribute a PR? (No is ok!)

None
@dubajj dubajj added the bug Something isn't working label Jan 4, 2024
@dubajj dubajj changed the title [Bug]: Cannot update a part, new part is always added [Bug]: Cannot update part type, new part is always added Jan 4, 2024
@replaysMike replaysMike self-assigned this Jan 8, 2024
@oskotsur
Copy link

oskotsur commented Feb 21, 2024 •
edited
Loading

Confirm the bug and add some details.
The bug is reproduced only if the original chip type is "IC" which you want to change to another type. If the original type differs from IC, edit works fine.

@replaysMike replaysMike added this to the v2.6.1 milestone Mar 8, 2024
@replaysMike replaysMike added the in-progress This ticket is currently being worked on label Mar 8, 2024
replaysMike added a commit that referenced this issue Mar 12, 2024
@replaysMike
fixes #246 - Cannot update part type, new part is always added
c421bc9
@replaysMike
Copy link
Owner

Fixed in v2.6.1 (release coming shortly)

@replaysMike replaysMike mentioned this issue Mar 13, 2024
Merged
replaysMike added a commit that referenced this issue Mar 13, 2024
@replaysMike
fixes #246 - Cannot update part type, new part is always added
c5af1ba
@replaysMike replaysMike removed the in-progress This ticket is currently being worked on label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@replaysMike replaysMike

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.6.1
Development

Successfully merging a pull request may close this issue.

Releases/v2.6.1 replaysMike/Binner
3 participants
@dubajj @replaysMike @oskotsur