Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show app config navbar for Embedded Cluster #5084

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

miaawong
Copy link
Member

@miaawong miaawong commented Jan 7, 2025

What this PR does / why we need it:

https://replicated.slack.com/archives/C0499EGNPNY/p1736268683199299

Which issue(s) this PR fixes:

[sc-118290]
https://app.shortcut.com/replicated/story/118290/investigate-lack-of-config-menu-in-ec-kots

Does this PR require a test?

Does this PR require a release note?

Fixes an issue where the Config navbar was not visible on the Config page

Does this PR require documentation?

@miaawong miaawong added type::bug Something isn't working bug::regression labels Jan 7, 2025
laverya
laverya previously approved these changes Jan 7, 2025
@laverya
Copy link
Member

laverya commented Jan 7, 2025

I figured out why this exists:
image

During the first time install process we'd otherwise have two copies of the nav sidebar - so we need to disable it there but not elsewhere

@miaawong miaawong marked this pull request as ready for review January 7, 2025 22:11
@miaawong miaawong requested a review from laverya January 7, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::regression type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants