Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration testing #170

Merged
merged 2 commits into from
Apr 10, 2023
Merged

integration testing #170

merged 2 commits into from
Apr 10, 2023

Conversation

laverya
Copy link
Member

@laverya laverya commented Apr 10, 2023

No description provided.

@laverya laverya force-pushed the laverya/integration-testing branch 2 times, most recently from 00f1544 to 76b501b Compare April 10, 2023 04:34
@laverya laverya marked this pull request as ready for review April 10, 2023 04:35
@laverya laverya force-pushed the laverya/integration-testing branch from 76b501b to e2b0624 Compare April 10, 2023 04:39
@laverya laverya force-pushed the laverya/integration-testing branch from e2b0624 to f5487db Compare April 10, 2023 04:45
@laverya
Copy link
Member Author

laverya commented Apr 10, 2023

I will need to change the required test names, of course

emosbaugh
emosbaugh reviewed Apr 10, 2023
View reviewed changes
Copy link
Member

@emosbaugh emosbaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a difference between explicitly setting the storageclass (storageClassName: int-source) vs is-default? should we add a test for both?

@laverya
Copy link
Member Author

laverya commented Apr 10, 2023

I don't think there's a difference, but I agree we should have a test that uses the default storageclass in the future

@laverya laverya merged commit e96a6b4 into main Apr 10, 2023
@laverya laverya deleted the laverya/integration-testing branch April 10, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emosbaugh emosbaugh emosbaugh approved these changes

Assignees
No one assigned
Labels
type::chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laverya @emosbaugh