New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle >63 character long PVC names #171

Merged

laverya merged 2 commits into main from laverya/long-pvc-name-integration-test

Apr 22, 2024

Member

laverya commented Apr 12, 2023 •

edited

Loading

Closes #155.

The general idea is to stop storing PVC names in labels, and instead:

lint for PVC names > 240 characters, and exit early
purely add a suffix to create PVC names, and do not store the original name in a label
stop truncating PVC names at 63 characters


          add a >63 character pvc name to the integration test

57eb7f6

laverya added type::bug bug::normal labels


          Merge branch 'main' into laverya/long-pvc-name-integration-test

659a057

clementnuss mentioned this pull request

Fix/ handle long pvc names #248

Merged

laverya merged commit 88f649c into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug::normal type::bug