Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return false for integration.IsEnabled if key unset in replicated secret #139

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dexhorthy
Copy link
Member

@dexhorthy dexhorthy commented Jan 27, 2024

What this PR does / why we need it:

The logic here appears to be flipped - if the integration key is absent or empty, I would guess that means "false"

Steps to reproduce

  • Do any standard SDK install (i.e. not in integration mode)
  • curl the /api/v1/app/info endpoint via your desired route (exec, port-forward, etc)
  • receive mock data with incorrect helmChartURL and currentRelease
{
  "appSlug": "slackernews-dexter-s-version",
  "appName": "SlackerNews (Dexter's Version)",
  "appStatus": "ready",
  "helmChartURL": "oci://registry.replicated.com/dev-app/dev-channel/dev-parent-chart",
  "currentRelease": {
    "versionLabel": "0.1.3",
    "releaseNotes": "release notes 0.1.3",
    "createdAt": "2023-05-23T20:58:07Z",
    "deployedAt": "2023-05-23T21:58:07Z",
    "helmReleaseName": "dev-parent-chart",
    "helmReleaseRevision": 3,
    "helmReleaseNamespace": "default"
  }
}

Does this PR introduce a user-facing change?

Fix a bug in the evaluation of "integration mode" for `/api/v1/app/info` and other related endpoints

Does this PR require documentation?

No, bug fix

divolgin
divolgin previously approved these changes Dec 11, 2024
Copy link
Member

@divolgin divolgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either this change is wrong or tests are wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants