Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Is it cryptography required? #131

Closed
1 task done
kairoaraujo opened this issue Nov 3, 2022 · 1 comment · Fixed by #182
Closed
1 task done

Bug: Is it cryptography required? #131

kairoaraujo opened this issue Nov 3, 2022 · 1 comment · Fixed by #182
Labels
bug Something isn't working needs-triage The issue needs triage

Comments

@kairoaraujo
Copy link
Member

What happened?

Cannot load the keys during the ceremony in a fresh installation

╔══════════════════════════════════════════════════════════════════════════════════════════════════╗
║                                     STEP 2: Load roles keys                                      ║
╚══════════════════════════════════════════════════════════════════════════════════════════════════╝

The keys must have a password, and the file must be accessible.                                     

Depending on the Organization, each key has an owner, and each owner should insert the password     
personally.                                                                                         

The Ceremony process doesn't show the password or key content.                                      

Ready to start loading the keys? Passwords will be required for keys [y/n]: y

Enter 1/2 the root`s Key path: tests/files/JanisJoplin.key
Enter 1/2 the root`s Key password: 
❌ Failed: RSA key support requires the cryptography library
Try again? [y/n] (y): y

Enter 1/2 the root`s Key path: tests/files/JanisJoplin.key
Enter 1/2 the root`s Key password: 
❌ Failed: RSA key support requires the cryptography library
Try again? [y/n] (y): y

Enter 1/2 the root`s Key path: tests/files/JanisJoplin.key

What steps did you take?

  1. Use clean setup
  2. Add the CLI
  3. Login (rstuf admin login)
  4. Run the ceremony (rstuf admin ceremony)

What behavior did you expect?

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kairoaraujo kairoaraujo added bug Something isn't working needs-triage The issue needs triage CRITICAL Feature is broken and removed CRITICAL Feature is broken labels Nov 3, 2022
@KAUTH
Copy link
Collaborator

KAUTH commented Jan 22, 2023

I verified this as well.

The cryptography package is a dependency of the securesystemslib package, to be exact it is an optional dependency (secure-systems-lab/securesystemslib#482). Therefore, we need to install at least the crypto extra (we should check if we are using any other features as well from securesystemslib).

With my PR fix I don't see this error, but following the same steps as above I get:

❌ Failed: Invalid encrypted file. Check the password.

This might have to do with my key however, can someone verify the fix from their side?

KAUTH added a commit that referenced this issue Jan 22, 2023
The `cryptography` package is a dependency of the `securesystemslib`
package, to be exact it is an _optional_ dependency.
`securesystemslib` uses "optional dependencies" ("extras") to allow
a default installation with limited capabilities.
However, since we are making use of the `cryptography` library
via `securesystemslib`, we need to install at least the `crypto`
extra.

Fixes #131

Signed-off-by: Konstantinos Papadopoulos <[email protected]>
KAUTH added a commit that referenced this issue Jan 23, 2023
The `cryptography` package is a dependency of the `securesystemslib`
package, to be exact it is an _optional_ dependency.
`securesystemslib` uses "optional dependencies" ("extras") to allow
a default installation with limited capabilities.
However, since we are making use of the `cryptography` library
via `securesystemslib`, we need to install at least the `crypto`
extra.

Fixes #131

Signed-off-by: Konstantinos Papadopoulos <[email protected]>
KAUTH added a commit that referenced this issue Jan 24, 2023
The `cryptography` package is a dependency of the `securesystemslib`
package, to be exact it is an _optional_ dependency.
`securesystemslib` uses "optional dependencies" ("extras") to allow
a default installation with limited capabilities.
However, since we are making use of the `cryptography` library
via `securesystemslib`, we need to install at least the `crypto`
extra.

Fixes #131

Signed-off-by: Konstantinos Papadopoulos <[email protected]>
KAUTH added a commit that referenced this issue Jan 24, 2023
The `cryptography` package is a dependency of the `securesystemslib`
package, to be exact it is an _optional_ dependency.
`securesystemslib` uses "optional dependencies" ("extras") to allow
a default installation with limited capabilities.
However, since we are making use of the `cryptography` library
via `securesystemslib`, we need to install at least the `crypto`
extra.

Fixes #131

Signed-off-by: Konstantinos Papadopoulos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage The issue needs triage
Projects
None yet
2 participants