Extract plugin tests #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help me understand the code before tackling issue #3, I decided to jump into the tests. It was helpful to split them out, so that I could see how each plugin acts in isolation.
I wanted to have tests for the
syncandupdatemethods ofSettings.js, but I couldn't figure out how to get the mocks setup correctly to do so. I wanted those tests to just show the specific duties of those functions, since it is really separate from any one plugin.I'm not a JS developer, and Google couldn't quite get me far enough. If someone could lead me in the right direction, I'd appreciate it. Or this could be merged, and the other tests left for another PR. It's not my project, so I'll let you all make that call.
/cc @bkeepers