Bugfix/fix reqnroll.verify parallelization #255
Merged
+220
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow Reqnroll.Verify to run in parallel by registering a per-scenario VerifySettings - Added documentation on how to use Reqnroll.Verify.
gasparnagy
reviewed
Sep 12, 2024
gasparnagy
requested changes
Sep 12, 2024
Plugins/Reqnroll.Verify/Reqnroll.Verify.ReqnrollPlugin/VerifyRuntimePlugin.cs
Outdated
Show resolved
Hide resolved
- Removed example for using verify in a single-threaded context as we would like users to not use that approach.
gasparnagy
added a commit
that referenced
this pull request
Oct 14, 2024
* main: Bump version VS Code integration proper doc title (#280) Fix: Reqnroll generates invalid code for rule backgrounds in Visual Basic (#284) Update nunit.md (#276) SolutionTests: Check if SDK version is installed and if not ignore the test (#266) Fix for #271 This PR modifies the Feature AST visitor to appropriately handle Rule Background steps. (#272) Bugfix/fix reqnroll.verify parallelization (#255)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Changed the Reqnroll.Verify code to register a VerifySettings object per scenario, so that users can use this to execute the verify method correctly.
⚡️ What's your motivation?
Fixes #254
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I see no way to verify that it does not work in parallel when not using the new settings object as it depends on the order executed and so sometimes will fail and sometimes not. (The first test that is ran most likely will always succeed.)
📋 Checklist: