Microsoft.Extensions Plugin - Create abstraction and improve unit tests

[304NotModified]

🤔 What's changed?

Changed the abstraction of the Reqnroll.Microsoft.Extensions.DependencyInjection.ServiceCollectionFinder

⚡️ What's your motivation?

So I tried to change the plugin, but it was missing tests. I made a new abstraction so the Finder is easy to test.

🏷️ What kind of change is this?

• 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

• The new interfaces (internal)
• The internalsvisibleto
• A bug? The AddBindingAttributes is called for every assembly and loops also the assemblies? This was the original code? Looks wrong to me

📋 Checklist:

• get feedback

[304NotModified]

So I missed https://github.com/orgs/reqnroll/discussions/472

Maybe we could use this code/idea or not. I haven't read it in its entirety yet

[gasparnagy]

The idea makes sense.
One addition: While working on the DI prototype, I realized that the binding assemblies can be queried in an easier way: ITestRunnerManager.BindingAssemblies (the ITestRunnerManager is registered in the test run (global) context so accessible everywhere.

[304NotModified]

is it useful to continue with this, as we have https://github.com/orgs/reqnroll/discussions/472?

Im also fine to fully focus on https://github.com/orgs/reqnroll/discussions/472

[gasparnagy]

I'm ok with both, but you are right it is probably easier to see the necessary abstractions once we have the new model merged in.

[304NotModified]

I was wrong this one. We could mock Assembly as it's an abstract class, so we do need this abstraction