Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LinkedIn OAuth #382

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions docs/examples/linkedin.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,26 @@ command line interactive example below.
>>> client_secret = '<the secret you get from linkedin>'

>>> # OAuth endpoints given in the LinkedIn API documentation
>>> authorization_base_url = 'https://www.linkedin.com/uas/oauth2/authorization'
>>> token_url = 'https://www.linkedin.com/uas/oauth2/accessToken'
>>> authorization_base_url = 'https://www.linkedin.com/oauth/v2/authorization'
>>> token_url = 'https://www.linkedin.com/oauth/v2/accessToken'

>>> from requests_oauthlib import OAuth2Session
>>> from requests_oauthlib.compliance_fixes import linkedin_compliance_fix

>>> linkedin = OAuth2Session(client_id, redirect_uri='http://127.0.0.1')
>>> linkedin = OAuth2Session(client_id, redirect_uri='https://localhost/')
>>> linkedin = linkedin_compliance_fix(linkedin)

>>> # Redirect user to LinkedIn for authorization
>>> authorization_url, state = linkedin.authorization_url(authorization_base_url)
>>> print 'Please go here and authorize,', authorization_url
>>> print('Please go here and authorize,', authorization_url)

>>> # Get the authorization verifier code from the callback url
>>> redirect_response = raw_input('Paste the full redirect URL here:')

>>> # Fetch the access token
>>> linkedin.fetch_token(token_url, client_secret=client_secret,
... authorization_response=redirect_response)
... authorization_response=redirect_response,include_client_id=True)

>>> # Fetch a protected resource, i.e. user profile
>>> r = linkedin.get('https://api.linkedin.com/v1/people/~')
>>> print r.content
>>> r = linkedin.get('https://api.linkedin.com/v2/me')
>>> print(r.json())
9 changes: 1 addition & 8 deletions requests_oauthlib/compliance_fixes/linkedin.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from json import loads, dumps

from oauthlib.common import add_params_to_uri, to_unicode
from oauthlib.common import to_unicode


def linkedin_compliance_fix(session):
Expand All @@ -10,12 +10,5 @@ def _missing_token_type(r):
r._content = to_unicode(dumps(token)).encode("UTF-8")
return r

def _non_compliant_param_name(url, headers, data):
token = [("oauth2_access_token", session.access_token)]
url = add_params_to_uri(url, token)
return url, headers, data

session._client.default_token_placement = "query"
session.register_compliance_hook("access_token_response", _missing_token_type)
session.register_compliance_hook("protected_request", _non_compliant_param_name)
return session
7 changes: 0 additions & 7 deletions tests/test_compliance_fixes.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,6 @@ def test_fetch_access_token(self):
)
self.assertEqual(token, {"access_token": "linkedin", "token_type": "Bearer"})

def test_protected_request(self):
self.session.token = {"access_token": "dummy-access-token"}
response = self.session.post("https://api.linkedin.com/v1/people/~/shares")
url = response.request.url
query = parse_qs(urlparse(url).query)
self.assertEqual(query["oauth2_access_token"], ["dummy-access-token"])


class MailChimpComplianceFixTest(TestCase):
def setUp(self):
Expand Down