Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is possible to create a double barcode item #3540

Closed
PascalRepond opened this issue Nov 23, 2023 · 0 comments · Fixed by rero/ng-core#580
Closed

It is possible to create a double barcode item #3540

PascalRepond opened this issue Nov 23, 2023 · 0 comments · Fixed by rero/ng-core#580
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries UX User experience, ergonomy

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Nov 23, 2023 •
edited
Loading

Bug description:

If I create an item and click on "save" (or Enter) multiple times, the item is saved twice with the same barcode.

Expected behavior:

There should be a security in the editors that prevents multiple button clicks to save any resource multiple times.

Steps to Reproduce:

  1. Create an item
  2. Multi-click on the "save" button
  3. See that the item is saved twice with the same barcode
@PascalRepond PascalRepond added bug Breaks something but is not blocking UX User experience, ergonomy labels Nov 23, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Nov 23, 2023
@PascalRepond PascalRepond added the client request Issue reported by production libraries label Nov 30, 2023
@Garfield-fr Garfield-fr moved this from Product Backlog to In Development in RERO ILS issues Nov 30, 2023
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Nov 30, 2023
@Garfield-fr
editor: enable/disable save button
af61330 
Enable or disable save button depending on form status.

* Closes rero/rero-ils#3540.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Nov 30, 2023
Closed
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Nov 30, 2023
@Garfield-fr
editor: enable/disable save button
e70a0eb 
Enable or disable save button depending on form status.

* Removes tests that do nothing on ng-core-tester.
* Closes rero/rero-ils#3540.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr moved this from In Development to Ready to test in RERO ILS issues Nov 30, 2023
Garfield-fr added a commit to rero/ng-core that referenced this issue Nov 30, 2023
@Garfield-fr
editor: enable/disable save button
b363b51 
Enable or disable save button depending on form status.

* Removes tests that do nothing on ng-core-tester.
* Closes rero/rero-ils#3540.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr moved this from Ready to test to In testing in RERO ILS issues Nov 30, 2023
@Garfield-fr Garfield-fr moved this from In testing to In Development in RERO ILS issues Dec 4, 2023
@Garfield-fr Garfield-fr moved this from In Development to Product Backlog in RERO ILS issues Dec 4, 2023
@Garfield-fr Garfield-fr removed their assignment Dec 4, 2023
@Garfield-fr Garfield-fr moved this from Product Backlog to Sprint backlog in RERO ILS issues Jan 8, 2024
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Jan 8, 2024
@Garfield-fr
editor: disabled save button on first click
1e50e1f 
To avoid double-clicking on the save button, it is deactivated on
the first click. If the form has errors, it is reactivated.

* Closes rero/rero-ils#3540.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Jan 8, 2024
Merged
@Garfield-fr Garfield-fr moved this from Sprint backlog to In Development in RERO ILS issues Jan 8, 2024
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Jan 8, 2024
@Garfield-fr
editor: disabled save button on first click
1b8030d 
To avoid double-clicking on the save button, it is deactivated on
the first click. If the form has errors, it is reactivated.

* Closes rero/rero-ils#3540.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Jan 8, 2024
@Garfield-fr
editor: disabled save button on first click
ae79705 
To avoid double-clicking on the save button, it is deactivated on
the first click. If the form has errors, it is reactivated.

* Closes rero/rero-ils#3540.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr moved this from In Development to Ready to test in RERO ILS issues Jan 8, 2024
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Jan 9, 2024
@Garfield-fr
editor: disabled save button on first click
a1bce34 
To avoid double-clicking on the save button, it is deactivated on
the first click. If the form has errors, it is reactivated.

* Closes rero/rero-ils#3540.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/ng-core that referenced this issue Jan 10, 2024
@Garfield-fr
editor: disabled save button on first click
d2db0a4 
To avoid double-clicking on the save button, it is deactivated on
the first click. If the form has errors, it is reactivated.

* Closes rero/rero-ils#3540.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@github-project-automation github-project-automation bot moved this from Ready to test to Done in RERO ILS issues Jan 10, 2024
@PascalRepond PascalRepond mentioned this issue Apr 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries UX User experience, ergonomy
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
2 participants
@Garfield-fr @PascalRepond