Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next version (primeng) #3805

Draft
wants to merge 4 commits into
base: staging
Choose a base branch
from
Draft

Next version (primeng) #3805

wants to merge 4 commits into from

Conversation

jma
Copy link
Contributor

@jma jma commented Dec 18, 2024

No description provided.

@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data developers From a developer point of view. dev: documentation About changelog, release notes, installation procedures, gh templates... f: user management f: data migration Data migration from a legacy system or a previous version labels Dec 18, 2024
@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Dec 19, 2024

PO tests

  • Editor: cannot select a contribution role. [REP: the editor has not been done yet]
  • Global style:
    • A lot of colours seem kind of washed out. Example: text in the description tab (I would prefer full black instead of gray), menu buttons. Could everything be a little darker to have more contrast/readability? [maj]: need a RERO theme
    • The global font-size would be better at "1" instead of 0.85
    • Brief views: slightly reduce the width of the facet column (by ~1/4) [maj]: need a discussion about the whole viewport
    • Brief views: slightly reduce the width of the result list (by ~1/3) [maj]: need a discussion about the whole viewport
    • Brief views: add icons to the sort menu and remove the "..."
  • Pro detailed views:
    • Document detail: The first item should be expanded on page load [maj]: check if it is fixed within the new version
    • The delete button is grayed out but doesn't say why (there was a modal in the previous version to say "2 holdings attached")
    • Document/item detail: "operation history" and "circulation history" buttons should be outline-gray
    • Add left and right margins around the content for wide screens so that the data is not spread on the whole viewport. (ILL requests, patron, item? to be experimented) [maj]: need a discussion about the whole viewport
    • [nice-to-have] Use gray card headers (ILL requests, patron, item?)
  • Flash message: a little bit too much space between title and content
    image
  • Alternate color style for lists: [nice-to-have] the first row should be gray
  • The user menu is always outside the window and buttons don't work:
    image [maj]: see Menubar: the display is not correct if the menu is on the right primefaces/primeng#15932
  • Editors: $ref dropdown fields option is not loaded on page init, I need to touch the field to see it (e.g. ILL request editor: pickup location)
  • Sometimes going for a "edit" or "delete" button, I hover the menu and it automatically opens, hiding the button I want. Is there a setting to make these menus open on click instead of hover?

@jma

This comment was marked as resolved.

@PascalRepond
Copy link
Contributor

PascalRepond commented Jan 8, 2025

PO tests (entites)

  • Delete buttons should be hidden for remote entites (brief views)
  • Buttons should all be same size (detailed view)
    image
  • [not-blocking] Content of the entities detailed view would be nicer as "Cards" instead of "accordions"

@PascalRepond
Copy link
Contributor

PascalRepond commented Jan 9, 2025

PO tests (reports and stats)

  • Fees brief view: some facets titles not translated (Amount recieved, Transaction_date)
  • Stat reports editor: distribution selection doesn't work
  • Stat reports editor: sometimes "Period" field should be hidden from editor for certain indicators (e.g.: Catalog->Number of documents)
  • Global (style) [for when we override the theme]: spacing between lines of standard text could be a little bit bigger

@PascalRepond
Copy link
Contributor

PascalRepond commented Jan 16, 2025

PO tests (admin menu)

  • Editors: when all fields have been added, there is still a box for essential fields, this could be hidden.
    image
  • Library editor: Button "Add" location is displayed even when menu is collapsed
    image

@github-actions github-actions bot removed the developers From a developer point of view. label Jan 28, 2025
@PascalRepond
Copy link
Contributor

PascalRepond commented Jan 30, 2025

PO tests (acquisitions)

  • When an order is fully recieved, the receipt line cannot be edited but the button is still available and leads to a 403 error.
  • [nice to have]: a button "expand all/collapse all" in the acquisition accounts' view
  • Accounts detailed view says "Fiscal year closed" even though the budget is active: https://ilsdev.test.rero.ch/professional/records/acq_accounts/detail/15
  • Use different grid columns in the order brief view to avoid align problems
    image

@PascalRepond
Copy link
Contributor

PascalRepond commented Feb 4, 2025

PO tests (circulation)

  • Menu to go back to public interface doesn't work
  • Add a fee modal: selecting type (dropdown) doesn't work on first click.
  • Pro patron profile "change password" modal:
    • quit modal doesn't work on first click
    • generate password button doesn't work on first click
    • The field should be grayed out as it cannot be manually entered, only generated.
    • [not-blocking] on generate, the alert to say "password was copied to the clipboard" is not displayed anymore
  • Direct checkin item:
    • errors in console and interface crash
    • alerts about item/loan not displayed
    • icons not displayed correctly in the table header (left and right)
    • Table header not displayed when scanning an item not linked to a loan
  • [not blocking] Tab pending + requests view: Small wrap text problem with long (generated) barcodes
    image
  • At desk tab: console error (string contains an invalid character): see https://ilsdev.test.rero.ch/professional/circulation/patron/kad001/pickup with item 2768

General

  • Document detailed view, serial holdings/items:
    • Spacing is weird on items buttons
    • Holdings delete button is blue instead of red
      image

@PascalRepond
Copy link
Contributor

PascalRepond commented Feb 6, 2025

PO tests - editors

Global

  • dropdown list items are not dynamically translated when switching language (e.g. cipo editor)
    image
  • Sometimes clicking a field on a new editor will validate the whole form and the action won't work. To reproduce: go to item type editor and click on the boolean toggle or to add a new subfield. See that the button was not activated.

User/patron

  • Patron editor won't save with empty local_code field.
  • Console error "Impossible de vérifier car « /^[a-zA-Z0-9-_]{2,255}$/v » n’est pas une expression régulière valide : character class escape cannot be used in class range in regular expression"
  • Password field in user editor should be grayed out (cannot be set manually).
  • User cannot be saved.

Local fields

  • Impossible to save

Document

Holdings

Stat report config

  • Distributions: bug with multi-select dropdown

Circulation policy

  • Reminders field: button to add a subfield not translated and not updated by field content
    image
  • Console error: "Formly: Invalid prop 'required' of type 'number', expected 'boolean' (Field:renewal_duration)."

Item type

  • Display displayed_status and circulation_information as cards for better readability.

Patron type

  • Disable toggle-wrappers, useless

Library

  • Error in exception dates when trying to save certain existing data in fixtures ("'2025-03-03T00:00:00.000+01:00' is not a 'date'.")
    • Check dates in other editors that are not in fixture data? E.g.: end date for temporary item type in item editor.

Template

  • If I want to load a template (e.g. from the document editor), the modal is small and the dropdown does not expand out of it.
    image
  • Various console errors when trying to load or save a template (probably linked to document editor).

✅ OK

  • Item
  • ILL request
  • Exhibition/course
  • Order
  • Local entity
  • Vendor

Garfield-fr and others added 4 commits February 10, 2025 14:36
Co-Authored-by: Bertrand Zuchuat <[email protected]>
* Adds missing format alias on the the REST API.
* Adds placeholder on the contries editor.
* All document detailed view tabs is done in angular.
* Removes useless document views.
* Removes useless document jinja template filters and their corresponding tests.
* Adds layer to css styles to avoid primeng and bootstrap conflicts.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
* Removes css class for the professional view.
* Adapts the main search component to the new ui version.
* Fixes several details in the patron editor.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: documentation About changelog, release notes, installation procedures, gh templates... f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: user management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants