users: remove Flask user

* removes Flask user when an user record is deleted. * Closes #491. Co-Authored-by: Sébastien Délèze <[email protected]>
rero · Feb 23, 2021 · 58437fd · 58437fd
1 parent 64ecc48
commit 58437fd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/sonar/modules/users/api.py b/sonar/modules/users/api.py
@@ -156,8 +156,8 @@ def delete(self, force=False, dbcommit=True, delindex=False):
         # Remove roles from user account.
         self.remove_roles()
 
-        # Deactivate account.
-        datastore.deactivate_user(self.user)
+        # Delete account.
+        datastore.delete_user(self.user)
 
         return super(UserRecord, self).delete(force=force,
                                               dbcommit=dbcommit,

diff --git a/tests/ui/users/test_users_api.py b/tests/ui/users/test_users_api.py
@@ -138,8 +138,7 @@ def test_delete(app, admin):
     with app.app_context():
         datastore = app.extensions['security'].datastore
         user = datastore.find_user(email='[email protected]')
-        assert not user.roles
-        assert not user.is_active
+        assert not user
 
 
 def test_update(app, admin, roles):