Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conferences should be displayed with number, place and date #338

Closed
pronguen opened this issue Oct 6, 2020 · 3 comments · Fixed by #355
Closed

Conferences should be displayed with number, place and date #338

pronguen opened this issue Oct 6, 2020 · 3 comments · Fixed by #355

Comments

@pronguen
Copy link
Contributor

pronguen commented Oct 6, 2020

Problem
Conferences are display with only their name.

Expected behaviour
They should be displayed as follows:
Name (Number : Date : Place)

This concerns the public and professional views AND the brief and detailed views.

Example: http://data.rero.ch/01-1983505/html

@sebdeleze
Copy link
Contributor

sebdeleze commented Oct 19, 2020

Just a dummy question, with type bf:Meeting, the role is mandatory in the editor, is that right? If yes, I will display something like this?:

Conference name (Number : Date : Place) (contributor)

And number, date and place should be mandatory in the editor if the type is bf:Meeting?

@pronguen
Copy link
Contributor Author

Yes, the role is always mandatory. Indeed, it is not relevant to display it in the case of bf:Meeting. If you want to implement this exception, you are welcome, but it is not that important.
No, number, date and place should NOT be mandatory... there is always a case where one of them is not known at the cataloguing.

@sebdeleze
Copy link
Contributor

Thanks!

sebdeleze pushed a commit that referenced this issue Oct 21, 2020
This commit displays the complete meeting information, with number, place and date.

* Creates a view filter to format contribution display.
* Adds the formatted text before serialization.
* Removes the formatted text before JSON loading.
* Displays the formatted text in record detail view.
* Registers the i18n extension in API application, to make the translations available.
* Closes #338.

Co-Authored-by: Sébastien Délèze <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants