Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User welcome email focuses on global SONAR instead of the user's organisation (dedicated only) #684

Closed
mmo opened this issue Nov 1, 2021 · 0 comments · Fixed by #703
Closed
Assignees
Labels
bug Breaks something but is not blocking

Comments

@mmo
Copy link
Collaborator

mmo commented Nov 1, 2021

The email states:

Subject: Welcome to SONAR
An account has been created for you on SONAR, the Institutional repository of [Organisation name].
...
To access it, please [reset your password]

After the user resets its password, it is redirected to global SONAR

This behaviour is appropriate for shared spaces, but not for dedicated portals. Expected behavior for dedicated portals:

Subject: Welcome to [Platform name]
An account has been created for you on [Platform name]
...
To access it, please [reset your password]

After the user resets its password, it is redirected to the organisation's portal (whether dedicated or shared)

Problem: currently, the platformName field is a Markdown text field - it should be converted to plain text (one-liner) for this email message.

Suggested recipe:

import markdown
from bs4 import BeautifulSoup
platform_name = '# MYPORTAL \n#### Institutional repository of Fictive Institution'
html = markdown.markdown(platform_name)
plain_platform_name = ''.join(BeautifulSoup(html).findAll(text=True)).replace('\n', ' - ')
print (plain_platform_name)
# Output is: MYPORTAL - Institutional repository of Fictive Institution
@mmo mmo changed the title User welcome email focuses on global SONAR instead of the user's organisation User welcome email focuses on global SONAR instead of the user's organisation (dedicated only) Nov 1, 2021
@mmo mmo added next-go-live bug Breaks something but is not blocking labels Nov 1, 2021
rerowep added a commit to rerowep/sonar that referenced this issue Nov 10, 2021
* Closes rero#684

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/sonar that referenced this issue Nov 10, 2021
* Closes rero#684.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep mentioned this issue Nov 10, 2021
7 tasks
rerowep added a commit to rerowep/sonar that referenced this issue Nov 10, 2021
* Closes rero#684.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/sonar that referenced this issue Nov 15, 2021
* Closes rero#684.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/sonar that referenced this issue Nov 18, 2021
* Closes rero#684.

Co-Authored-by: Peter Weber <[email protected]>
jma pushed a commit that referenced this issue Nov 18, 2021
* Closes #684.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit that referenced this issue Dec 2, 2021
* Closes #684.

Co-Authored-by: Peter Weber <[email protected]>
@mmo mmo removed the next-go-live label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants