users: create user record on registration #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebdeleze
requested review from
zannkukai and
jma
and removed request for
zannkukai
jma
approved these changes
Jun 18, 2020
| @@ -67,9 +67,15 @@ def import_users(infile): | |||
| password = hash_password(password) | |||
| del user_data['password'] | |||
|
|
|||
| if not user_data.get('roles'): | |||
| user_data['roles'] = [UserRecord.ROLE_USER] | |||
There was a problem hiding this comment.
Why not having the roles in the fixtures file?
There was a problem hiding this comment.
Normally it's the case, it's just to insure that the user as at least the role "user".
| roles = [] | ||
|
|
||
| for role in roles: | ||
| if not datastore.find_role(role): |
There was a problem hiding this comment.
If this take while it can be afterward with a unique list of collected roles.
There was a problem hiding this comment.
Not really sure, because we need the roles to create user account just after. But maybe yes, we can collect all roles before and create them before creating users.
| :param user: User account. | ||
| """ | ||
| # Add a default role to user | ||
| role = datastore.find_role(UserRecord.ROLE_USER) |
There was a problem hiding this comment.
why not doing this in the UserRecord class?
There was a problem hiding this comment.
It's not related to UserRecord, but to Flask account created, which has no role.
* Creates a user record when a new account is registered. * Disables `invenio-userprofiles` module. * Exposes and uses user record for displaying user information in templates. * Gives role `user` by default when a new record is created. * Removes `organisation` from required fields for users. * Hides `applications` and `security` menu entries. * Creates a new page for editing user data. * Removes useless CSS rules * Adds CSS rules for standalone editor. * Customizes settings page. Co-Authored-by: Sébastien Délèze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invenio-userprofilesmodule.userby default when a new record is created.organisationfrom required fields for users.applicationsandsecuritymenu entries.Co-Authored-by: Sébastien Délèze [email protected]
How to test
Standard registration form
Switch edu-ID
ORCID