deposits: handle identifiedBy field.
#287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
approved these changes
Aug 28, 2020
The goal of this PR is to handle `identifiedBy` field in deposit process and create this field in document when deposit is validated. * Adds `identifiedBy` data to document when deposit is validated. * Adds `identifiedBy` field to deposit JSON schema so that the field is displayed in deposit form. * Moves `hideExpression` properties into `form` object to be consistent with `ng-core` editor. * Adds `editor-title` CSS class to main properties of deposit JSON schema. * Displays identifiers in document detail view. Co-Authored-by: Sébastien Délèze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to handle
identifiedByfield in deposit process and create this field in document when deposit is validated.identifiedBydata to document when deposit is validated.identifiedByfield to deposit JSON schema so that the field is displayed in deposit form.hideExpressionproperties intoformobject to be consistent withng-coreeditor.editor-titleCSS class to main properties of deposit JSON schema.Co-Authored-by: Sébastien Délèze [email protected]