Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: update name in organisation facet #321

Merged
merged 1 commit into from
Oct 21, 2020
Merged

documents: update name in organisation facet #321

merged 1 commit into from
Oct 21, 2020

Conversation

sebdeleze
Copy link
Contributor

@sebdeleze sebdeleze commented Sep 23, 2020

Set the name of the organisations instead of their codes in facet before sending response in API.

Co-Authored-by: Sébastien Délèze [email protected]

@sebdeleze sebdeleze changed the title documents: Update name in organisation facet documents: update name in organisation facet Sep 23, 2020
@sebdeleze sebdeleze marked this pull request as ready for review September 23, 2020 08:59
@sebdeleze sebdeleze requested a review from zannkukai September 23, 2020 09:01
@pronguen
Copy link
Contributor

pronguen commented Oct 8, 2020

  1. I edited the organisation name
  2. I checked a document of this organisation in the public search
  3. The value in the facet "Organisation" is still the code.

How do we have to test this?

Set the name of the organisations instead of their codes in facet before sending response in API.

* Sets the name of the organisation in corresponding facet in documents serializer.
* Removes useless manual translations for organisations.
* Closes #320.

Co-Authored-by: Sébastien Délèze <[email protected]>
@pronguen pronguen self-requested a review October 21, 2020 12:32
@sebdeleze sebdeleze merged commit 7d13f64 into rero:dev Oct 21, 2020
@sebdeleze sebdeleze deleted the sed-translate-org-facet branch October 21, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate values for 'organisation' facet
3 participants