deposits: add license #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
approved these changes
Oct 13, 2020
| @@ -319,7 +319,15 @@ | |||
| } | |||
| }, | |||
| "usageAndAccessPolicy": { | |||
| "type": "text" | |||
| "type": "object", | |||
There was a problem hiding this comment.
I do not understand why this property name is different between document and deposit...
There was a problem hiding this comment.
Because the deposit schema has been done a long time before adding the usageAndAccessPolicy property in document schemas. And I don't have the time to refactor it.
| {% if record.usageAndAccessPolicy %} | ||
| <p> | ||
| <small> | ||
| {% if record.usageAndAccessPolicy.label %} |
There was a problem hiding this comment.
It would be nice to have logos in the future.
There was a problem hiding this comment.
Thanks for the proposition, I will add a card in the kanban for this.
pronguen
reviewed
Oct 21, 2020
There was a problem hiding this comment.
- License text should be translated (esp. the "Not OA...")
- The license should be displayed with a label "License" just before the permalink. 1st line with the content of
usageAndAccessPolicy.license; 2nd line below without new label, with the content ofusageAndAccessPolicy.label
This PR aims to add a license to deposit and document records. Moreover, the `usageAndAccessPolicy` will be added when a record is imported from RERO DOC. * Creates a JSON schema for license property. * Creates the `usageAndAccessPolicy` property in documents when the document is created from a deposit. * Updates the `usageAndAccessPolicy` property of documents to match the specs. * Adds a `license` property in deposit's JSON schema. * Updates the conversion of field `540$a` to match the new structure of the `usageAndAccessPolicy` property. * Adds a default license for RERO DOC documents if the license is not set. * Makes the field `usageAndAccessPolicy` available when a document is serialized. * Displays the license in document's detail view. * Closes #324. Co-Authored-by: Sébastien Délèze <[email protected]>
The license value is marked for being translated. The extraction of this messages will be done in another PR on branch
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a license to deposit and document records. Moreover, the
usageAndAccessPolicywill be added when a record is imported from RERO DOC.usageAndAccessPolicyproperty in documents when the document is created from a deposit.usageAndAccessPolicyproperty of documents to match the specs.licenseproperty in deposit's JSON schema.540$ato match the new structure of theusageAndAccessPolicyproperty.usageAndAccessPolicyavailable when a document is serialized.Co-Authored-by: Sébastien Délèze [email protected]