authentication: fix Switch edu-ID authentication #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebdeleze
added
bug
|
The correction works! Other problem encountered (not prioritary): it is possible to create 2 users with the same e-mail, because of maj/min differences, see image.
|
* Fixes an issue when the accounts from Switch and Invenio are linked and the email address are not corresponding because of case sensivity. * Makes the check for the existence of a user email case insensitive. * Closes #397. Co-Authored-by: Sébastien Délèze <[email protected]>
I tried a fix, be not sure it's OK. If it's not the case, I suggest to create an issue with more details. |
pronguen
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Sébastien Délèze [email protected]