Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: add hiddenToPublic property #466

Merged
merged 1 commit into from
Feb 12, 2021
Merged

documents: add hiddenToPublic property #466

merged 1 commit into from
Feb 12, 2021

Conversation

sebdeleze
Copy link
Contributor

Adds a property to hide records in public views. This is needed for example for HEG, when a record has no file attached.

Co-Authored-by: Sébastien Délèze [email protected]

@sebdeleze sebdeleze added bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor labels Feb 5, 2021
@sebdeleze sebdeleze marked this pull request as ready for review February 5, 2021 09:41
@sebdeleze sebdeleze requested a review from jma February 8, 2021 15:20
Copy link

@BadrAly BadrAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use masked instead of hiddentopublic, HiddenFromPublic event better

Adds a property to hide records in public views. This is needed for example for HEG, when a record has no file attached.

* Adds the `hiddenToPublic` property to documents.
* Does not search for records having the flag activated.
* Throws a 404 in detail view when the flag is activated.
* Removes empty properties when `Unpaywall` record is serialized.
* Flags HEG record as hidden if no file is linked to it.
* Closes #464.

Co-Authored-by: Sébastien Délèze <[email protected]>
@sebdeleze sebdeleze merged commit 795a414 into rero:staging Feb 12, 2021
@sebdeleze sebdeleze deleted the sed-hide-property branch February 12, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide records which have no file attached, only if imported from HEG
3 participants