Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

view: change the view routes #533

Merged
merged 2 commits into from
May 11, 2021
Merged

view: change the view routes #533

merged 2 commits into from
May 11, 2021

Conversation

jma
Copy link
Contributor

@jma jma commented Apr 21, 2021 •
edited
Loading

  • Adds document and project detailed view in the invenio-records-ui
    configuration.
  • Adds permissions to the detailed, preview and file document views to
    limit the access to the public documents.
  • Adds front page route and the global jinja filters to the main
    extension application.
  • Adds a new werkzeug converter to limit the view matched routes to the
    existing organisations.
  • Use autoflake to detect unused import packages.

Co-Authored-by: Johnny Mariéthoz [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma
view: change the view routes
16d2e33 
* Adds document and project detailed view in the invenio-records-ui
  configuration.
* Adds permissions to the detailed, preview and file document views to
  limit the access to the public documents.
* Adds front page route and the global jinja filters to the main
  extension application.
* Adds a new werkzeug converter to limit the view matched routes to the
  existing organisations.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the maj-fix-routes branch from 8da4adb to 865e038 Compare April 21, 2021 12:47
@jma jma marked this pull request as ready for review April 21, 2021 12:48
@jma jma requested a review from sebdeleze April 21, 2021 12:48
sebdeleze
sebdeleze reviewed Apr 23, 2021
View reviewed changes
tests/ui/documents/test_documents_views.py Show resolved Hide resolved
sonar/route_converters.py Outdated Show resolved Hide resolved
sonar/ext.py Show resolved Hide resolved
@jma
tests: add useless python import checker
826af69 
* Use `autoflake` to detect unused import packages.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the maj-fix-routes branch from 865e038 to 826af69 Compare April 28, 2021 14:59
@jma jma requested a review from sebdeleze April 28, 2021 15:01
@sebdeleze sebdeleze merged commit 558c0a6 into rero:staging May 11, 2021
@sebdeleze sebdeleze deleted the maj-fix-routes branch May 11, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebdeleze sebdeleze sebdeleze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jma @sebdeleze