Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

projects: validation workflow #549

Merged
merged 1 commit into from
Jun 8, 2021
Merged

projects: validation workflow #549

merged 1 commit into from
Jun 8, 2021

Conversation

sebdeleze
Copy link
Contributor

  • Adds a validation workflow to projects for HEP Valais.
  • Adds a blueprint for validation email templates.
  • Adds fixtures for HEP Valais organisation.
  • Adds a JSON schema for storing validation data.
  • Creates an extension to process validation when a record is saved.
  • Adds a Marshmallow schema for validation data.
  • Adds emails for all actions and languages.
  • Adds a cached property in resource record to get the index name.
  • Adds a method to get the string representation of a project object.
  • Adjusts projects permissions depending on the status.
  • Enables facet and filter for project validation status.
  • Adds a mapping for validation data in Elasticsearch.
  • Closes Record validation workflow #457.

Co-Authored-by: Sébastien Délèze [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@sebdeleze sebdeleze marked this pull request as draft May 4, 2021 07:34
@sebdeleze sebdeleze marked this pull request as ready for review May 4, 2021 07:52
@sebdeleze sebdeleze requested review from jma and zannkukai May 17, 2021 11:21
jma
jma requested changes May 21, 2021
View reviewed changes
sonar/common/jsonschemas/validation-v1.0.0.json Show resolved Hide resolved
sonar/common/jsonschemas/validation-v1.0.0.json Outdated Show resolved Hide resolved
sonar/common/jsonschemas/validation-v1.0.0.json Show resolved Hide resolved
sonar/common/jsonschemas/validation-v1.0.0.json Show resolved Hide resolved
sonar/modules/validation/api.py Outdated Show resolved Hide resolved
sonar/modules/validation/templates/validation/email/validated/fr.txt Show resolved Hide resolved
sonar/resources/api.py Outdated Show resolved Hide resolved
sonar/resources/api.py Outdated Show resolved Hide resolved
sonar/resources/projects/permissions.py Show resolved Hide resolved
sonar/translations/manual_translations.txt Show resolved Hide resolved
@sebdeleze sebdeleze requested review from jma and removed request for zannkukai May 25, 2021 10:48
jma
jma previously requested changes May 26, 2021
View reviewed changes
sonar/resources/projects/permissions.py Show resolved Hide resolved
projects: validation workflow
727ffea 
* Adds a validation workflow to projects for HEP Valais.
* Adds a blueprint for validation email templates.
* Adds fixtures for HEP Valais organisation.
* Adds a JSON schema for storing validation data.
* Creates an extension to process validation when a record is saved.
* Adds a Marshmallow schema for validation data.
* Adds emails for all actions and languages.
* Adds a cached property in resource record to get the index name.
* Adds a method to get the string representation of a project object.
* Adjusts projects permissions depending on the status.
* Enables facet and filter for project validation status.
* Adds a mapping for validation data in Elasticsearch.
* Removes specific fields for projects in deposit process, to have a generic approach.
* Closes #457.

Co-Authored-by: Sébastien Délèze <[email protected]>
@sebdeleze sebdeleze dismissed jma’s stale review June 7, 2021 14:18

@jma approved the changes

@sebdeleze sebdeleze merged commit 428f148 into rero:staging Jun 8, 2021
@sebdeleze sebdeleze deleted the sed-validation-workflow branch June 8, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Record validation workflow
2 participants
@sebdeleze @jma