project: add collection resource
#566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2021 08:45
* Creates a new `collections` resource. * Enables files management for this new resource. Co-Authored-by: Sébastien Délèze <[email protected]>
* Links collections to documents. * Creates a collection and links it to document when a deposit is validated. * Creates a collection when a collection is found in RERO DOC publication. Co-Authored-by: Sébastien Délèze <[email protected]>
zannkukai
approved these changes
Jun 14, 2021
Comment on lines
+45
to
+61
| @classmethod | ||
| def create(cls, data, id_=None, dbcommit=False, with_bucket=True, | ||
| **kwargs): | ||
| """Create record. | ||
|
|
||
| :param dict data: Metadata of the new record | ||
| :param str id_: UUID to use if not generated | ||
| :param bool dbcommit: Wether to commit into DB during creation | ||
| :param bool with_bucket: Wether to create a bucket for record | ||
| :return: New record instance | ||
| :rtype: Record | ||
| """ | ||
| return super().create(data, | ||
| id_=id_, | ||
| dbcommit=dbcommit, | ||
| with_bucket=with_bucket, | ||
| **kwargs) |
There was a problem hiding this comment.
is this necessary if your create method did nothing more than class parent ?
Into RERO-ILS project, we skip this declaration into children classes if there are no specific process.
There was a problem hiding this comment.
Yes it's mandatory because I need to set the default value for with_bucket to True.
| schema = f'{RESOURCE_NAME}/{JSON_SCHEMA_NAME}-v1.0.0.json' | ||
| pid_type = PID_TYPE | ||
| resolver_url = f'/api/{RESOURCE_NAME}/<pid>' | ||
| rest_endpoint = { |
There was a problem hiding this comment.
I don't like PEP-8 80 characters line limit. Not easy to read :-)
There was a problem hiding this comment.
Completely agree with you, we should increase this limit.
* Adds a view to list the collections for an organisation. * Adds a block containing the collection information in the search view in the collection context. * Filters records corresponding to the collection in the collection context. * Hides collection aggregation in the collection context. Co-Authored-by: Sébastien Délèze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Sébastien Délèze [email protected]