Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: try to parse the thesis note from RERO DOC more precisely #650

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

mmo
Copy link
Collaborator

@mmo mmo commented Sep 20, 2021

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

documents: improve parsing of thesis note

* Tries to parse the thesis note from RERO DOC more precisely.

Co-Authored-by: Miguel Moreira <[email protected]>

Title: 50 chars max, infinitive verb.
Body: wrap at 72 chars, verbs at the 3rd singular person.
Always the Co-Authored-by signature, with github account e-mail.

I need to document it explicitly, I thought I did.
There's a git commit template for RERO ILS: https://github.com/rero/rero-ils/blob/dev/.gitmessage.txt (see https://github.com/rero/rero-ils/blob/dev/CONTRIBUTING.rst#get-started point 6.)

* Tries to parse the thesis note from RERO DOC more precisely.

Co-Authored-by: Miguel Moreira <[email protected]>
@mmo mmo force-pushed the mmo-parse-thesis-note branch from d7ccfea to 0092426 Compare October 5, 2021 13:58
@jma jma merged commit 6cd9c13 into rero:staging Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants