Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema: distinguish supervisor co-supervisors #745

Merged
merged 1 commit into from
Feb 2, 2022
Merged

schema: distinguish supervisor co-supervisors #745

merged 1 commit into from
Feb 2, 2022

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Dec 22, 2021

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@rerowep rerowep self-assigned this Dec 22, 2021
mmo
mmo requested changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@mmo mmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line

sonar/sonar/modules/documents/views.py

Line 220 in 2422b85

priorities = ['cre', 'ctb', 'dgs', 'edt', 'prt']
should be updated to:

    priorities = ['cre', 'ctb', 'dgs', 'dgc', 'edt', 'prt']

@rerowep rerowep force-pushed the wep-distinguish-supervisor-supervisors branch from c8b904a to 53c463d Compare January 26, 2022 07:47
@rerowep
Copy link
Contributor Author

rerowep commented Jan 26, 2022

priorities = ['cre', 'ctb', 'dgs', 'dgc', 'edt', 'prt']

Changed it.

@rerowep rerowep requested a review from mmo January 26, 2022 07:47
@rerowep rerowep force-pushed the wep-distinguish-supervisor-supervisors branch from 53c463d to 222272f Compare January 26, 2022 10:01
@rerowep
schema: distinguish supervisor co-supervisors
1ab7861 
* Distinguish between thesis supervisor and co-supervisors
* Adds dgc "Degree committee member" for field contribution.role in document and deposit.
* Closes rero#733

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-distinguish-supervisor-supervisors branch from 222272f to 1ab7861 Compare February 2, 2022 10:01
@jma jma merged commit d26a247 into rero:staging Feb 2, 2022
@rerowep rerowep deleted the wep-distinguish-supervisor-supervisors branch February 2, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pronguen pronguen pronguen approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@mmo mmo Awaiting requested review from mmo

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

distinguish between thesis supervisor and co-supervisors [1]
5 participants
@rerowep @Garfield-fr @mmo @pronguen @jma