webpack: custom configuration file #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok for me, but tests are not passing due to errors in MEF queries. I will check with @rerowep tomorrow. |
jma
force-pushed
the
maj-webpack-config
branch
2 times, most recently
from
469fa83 to
2593d49
Compare
jma
changed the title
sebdeleze
suggested changes
Oct 3, 2019
sonar/config.py
Outdated
| @@ -32,6 +32,7 @@ | |||
| from invenio_oauthclient.contrib import orcid | |||
| from invenio_records_rest.facets import terms_filter | |||
| from invenio_records_rest.utils import allow_all, check_elasticsearch | |||
| from pywebpack import WebpackProject | |||
There was a problem hiding this comment.
I think this import is not needed.
* BETTER Add a custom webpack configuration files. * FIX Update the pid property name for mef as it has been changed. Signed-off-by: Johnny Mariéthoz <[email protected]>
sebdeleze
force-pushed
the
maj-webpack-config
branch
from
2593d49 to
8c6d849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Johnny Mariéthoz [email protected]