Add helper functions for codec string and bit depth #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
include in changelog
6 tasks
jprochazk
reviewed
Oct 8, 2024
src/mp4box/av01.rs
Outdated
| @@ -19,7 +19,7 @@ pub struct Av01Box { | |||
| #[serde(with = "value_u32")] | |||
| pub vertresolution: FixedPointU16, | |||
| pub frame_count: u16, | |||
| pub depth: u16, | |||
| pub depth: u16, // I don't know what this is, but it is usually 24 | |||
There was a problem hiding this comment.
Pretty sure this is just bit depth, 3 channels * 8 bits per pixel = 24 bits total
There was a problem hiding this comment.
That's what I was about to write as well, especially since our av1 decoder also likes to talk in "total bits per full color sample" (i.e. 24/30/34). But then Emil told me on a call that he observed 24bit on a 10bit hdr video if I understood correctly.
Maybe worth pointing out here!
There was a problem hiding this comment.
I get depth: 24, bit_depth: 10 when I print both
Wumpf
approved these changes
Oct 8, 2024
Co-authored-by: Andreas Reich <[email protected]>
Co-authored-by: Andreas Reich <[email protected]>
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Oct 8, 2024
### What * Uses rerun-io/re_mp4#10 Improves the video blob info in two ways: * Adds bit depth (if known) * Shows human-redable name of codec (e.g. AV1 or H.264)    A warning will also be printed if trying to decode a HDR video (since we don't yet support that). Related: * #7594 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7633?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7633?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7633) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.