put in static logging into image_send_columns as intended

rerun-io · Aug 13, 2024 · 46c8a1f · 46c8a1f
1 parent 366a4e6
commit 46c8a1f
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 14 deletions.
diff --git a/crates/store/re_types/src/archetypes/image.rs b/crates/store/re_types/src/archetypes/image.rs
diff --git a/docs/snippets/all/archetypes/image_send_columns.cpp b/docs/snippets/all/archetypes/image_send_columns.cpp
@@ -32,11 +32,7 @@ int main() {
         rerun::ColorModel::RGB,
         rerun::ChannelDatatype::U8
     );
-    rec.log(
-        "images",
-        rerun::borrow(&format, 1),
-        rerun::Image::IndicatorComponent()
-    ); // TODO: make static
+    rec.log_static("images", rerun::borrow(&format, 1), rerun::Image::IndicatorComponent());
 
     // Split up the image data into several components referencing the underlying data.
     const size_t image_size_in_bytes = width * height * 3;

diff --git a/docs/snippets/all/archetypes/image_send_columns.py b/docs/snippets/all/archetypes/image_send_columns.py
@@ -17,7 +17,7 @@
 
 # Log the ImageFormat and indicator once, as static.
 format_static = rr.components.ImageFormat(width=width, height=height, color_model="RGB", channel_datatype="U8")
-rr.log("images", [format_static, rr.Image.indicator()])  # TODO:, static=True)
+rr.log("images", [format_static, rr.Image.indicator()], static=True)
 
 # Send all images at once.
 rr.send_columns(

diff --git a/docs/snippets/all/archetypes/image_send_columns.rs b/docs/snippets/all/archetypes/image_send_columns.rs
@@ -31,7 +31,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
     });
     rec.log_component_batches(
         "images",
-        false, // TODO: static=true,
+        true,
         [&format as _, &rerun::Image::indicator() as _],
     )?;
 

diff --git a/rerun_cpp/src/rerun/archetypes/image.hpp b/rerun_cpp/src/rerun/archetypes/image.hpp
diff --git a/rerun_py/rerun_sdk/rerun/archetypes/image.py b/rerun_py/rerun_sdk/rerun/archetypes/image.py