enable clang compatible warnings only on clang

rerun-io · Aug 10, 2023 · 565f760 · 565f760
1 parent 078d87e
commit 565f760
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -17,15 +17,21 @@ function(set_default_warning_settings target)
             -Wmissing-include-dirs
             -Wnull-dereference
             -Wpointer-arith
-            -Wshadow-all
+            -Wshadow
             -Wswitch-enum
             -Wvla
             -Wold-style-cast
-            -Wnon-gcc
-            -Wgnu
-            -Wc++17-compat-pedantic
         )
 
+        if(CMAKE_CXX_COMPILER_ID MATCHES "Clang") # match both "Clang" and "AppleClang"
+            target_compile_options(${target} PRIVATE
+                -Wc++17-compat-pedantic
+                -Wshadow-all
+                -Wnon-gcc
+                -Wgnu
+            )
+        endif()
+
         # Disabled warnings
         # arrow has a bunch of unused parameters in its headers.
         target_compile_options(${target} PRIVATE -Wno-unused-parameter)