Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depthmap lighting #1529

Open
rasmusgo opened this issue Mar 7, 2023 · 2 comments
Open

Depthmap lighting #1529

rasmusgo opened this issue Mar 7, 2023 · 2 comments
Labels
enhancement New feature or request 🔺 re_renderer affects re_renderer itself

Comments

@rasmusgo
Copy link
Contributor

rasmusgo commented Mar 7, 2023

Judging the quality of a depth map is hard when it is only colored by the depth because local details are lost. These details can become visible by computing normals and using them for lighting. An alternative to lighting is to simply display the normals by encoding them directly in rgb (as normals maps are typically done). Lighting is more flexible than coloring by normals because it also works together with other ways of coloring the depth data, eg by a colormap, solid color or an image from a color camera.

@rasmusgo rasmusgo added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Mar 7, 2023
@Wumpf Wumpf added 🔺 re_renderer affects re_renderer itself and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Mar 7, 2023
emilk added a commit that referenced this issue Jun 27, 2023
We should make people who file issues feel seen by commenting on them

Example output:

```
#1529 by rasmusgo has 0 comments
#1544 by cortwave has 0 comments
#1571 by pablovela5620 has 0 comments
```
@emilk
Copy link
Member

emilk commented Jun 27, 2023

There is more than one way of computing normals for a depth map though (e.g. look at just the closest four neighbors, or look at a larger neighborhood and ignore outliers, etc etc) so it is unlikely there will be a single solution that fits all.

So allowing users to log a separate normal for each pixel would make sense here. This will be easier once we have:

emilk added a commit that referenced this issue Jun 28, 2023
### What
We should make people who file issues feel seen by commenting on them

Example output:

```
#1529 by rasmusgo has 0 comments
#1544 by cortwave has 0 comments
#1571 by pablovela5620 has 0 comments
```

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2532

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/e91e000/docs
Examples preview: https://rerun.io/preview/e91e000/examples
<!-- pr-link-docs:end -->
emilk added a commit that referenced this issue Jun 29, 2023
### What
We should make people who file issues feel seen by commenting on them

Example output:

```
#1529 by rasmusgo has 0 comments
#1544 by cortwave has 0 comments
#1571 by pablovela5620 has 0 comments
```

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2532

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/e91e000/docs
Examples preview: https://rerun.io/preview/e91e000/examples
<!-- pr-link-docs:end -->
@haixuanTao
Copy link

+1. linking some documentation that does just this:

But I agree that it's not straightforward to make this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

No branches or pull requests

4 participants