New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor `app.rs` #2242

Closed

emilk opened this issue May 29, 2023 · 0 comments

Assignees

Labels

Member

emilk commented May 29, 2023 •

edited

Loading

Create a provisional in-memory "Data Hub"
- Break up app.rs into parts #2303
Prepare for:
- Show open recordings in side view above blueprints #2298
Misc cleanup

emilk added the 🚜 refactor label

emilk changed the title ~~Refactor app.rs~~ Refactor app.rs

emilk mentioned this issue

Limit the viewer to one blueprint open at a time #2252

Closed

emilk self-assigned this

emilk mentioned this issue

Break up app.rs into parts #2303

Merged

1 task

emilk added a commit that referenced this issue


          Break up app.rs into parts (#2303)

6d96d37

### What
Part of:
* #2242

Breaks up `app.rs` into several files. This required adding `pub(crate)`
on some fields. I plan to remove that in a future PR, creating accessors
and helpers instead.

This PR doesn't change behavior; it just moves code around.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2303

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/3ef7f88/docs
<!-- pr-link-docs:end -->

emilk closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment