Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and prevent re-used order attributes in same context #2680

Closed
Tracked by #2646
teh-cmc opened this issue Jul 12, 2023 · 0 comments · Fixed by #3517
Closed
Tracked by #2646

Detect and prevent re-used order attributes in same context #2680

teh-cmc opened this issue Jul 12, 2023 · 0 comments · Fixed by #3517
Labels
codegen/idl 🧑‍💻 dev experience developer experience (excluding CI)

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jul 12, 2023

Forbid the same order to be re-used in the same context (e.g. two objects in the same module, two fields in the same object, etc).
@teh-cmc teh-cmc added 🧑‍💻 dev experience developer experience (excluding CI) codegen/idl labels Jul 12, 2023
This was referenced Jul 12, 2023
Open
Open
@teh-cmc teh-cmc mentioned this issue Sep 18, 2023
Merged
3 tasks
@emilk emilk mentioned this issue Sep 28, 2023
Merged
3 tasks
emilk added a commit that referenced this issue Sep 28, 2023
@emilk
Force kwargs in codegened __init__ methods of Archetypes (#3517)
f8f8f24 
### What
* Closes of #3167
* Closes #2680

Force using named arguments for all optional parameters of our
archetypes

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3517) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3517)
- [Docs
preview](https://rerun.io/preview/efe3d1b213558467aeb97fbc2177b60495e82144/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/efe3d1b213558467aeb97fbc2177b60495e82144/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen/idl 🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Force kwargs in codegened __init__ methods of Archetypes rerun-io/rerun
1 participant
@teh-cmc